Skip to content

Commit 08c43bc

Browse files
committed
Swift: move diagnostics definition to the source file
1 parent 0d9dcb1 commit 08c43bc

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

swift/xcode-autobuilder/XcodeBuildLogging.h

Lines changed: 0 additions & 13 deletions
This file was deleted.

swift/xcode-autobuilder/XcodeBuildRunner.cpp

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,17 @@
55
#include <spawn.h>
66
#include "absl/strings/str_join.h"
77

8-
#include "swift/xcode-autobuilder/XcodeBuildLogging.h"
8+
#include "swift/logging/SwiftLogging.h"
9+
10+
namespace codeql_diagnostics {
11+
constexpr codeql::SwiftDiagnosticsSource build_command_failed{
12+
"build_command_failed",
13+
"Detected build command failed",
14+
"Set up a manual build command",
15+
"https://docs.github.com/en/enterprise-server/code-security/code-scanning/"
16+
"automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning",
17+
};
18+
}
919

1020
static codeql::Logger& logger() {
1121
static codeql::Logger ret{"build"};

swift/xcode-autobuilder/xcode-autobuilder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include "swift/xcode-autobuilder/XcodeTarget.h"
55
#include "swift/xcode-autobuilder/XcodeBuildRunner.h"
66
#include "swift/xcode-autobuilder/XcodeProjectParser.h"
7-
#include "swift/xcode-autobuilder/XcodeBuildLogging.h"
7+
#include "swift/logging/SwiftLogging.h"
88

99
static const char* Application = "com.apple.product-type.application";
1010
static const char* Framework = "com.apple.product-type.framework";

0 commit comments

Comments
 (0)