Skip to content

Commit 09ce29b

Browse files
committed
Merge branch 'codeql-cli-2.13.3' into redsun82/swift-hidden-ast
2 parents fce33d3 + a14f7dd commit 09ce29b

File tree

15 files changed

+10521
-113
lines changed

15 files changed

+10521
-113
lines changed

swift/downgrades/44e36e15e90bc1535964d9b86b3cd06a8b0d26e3/old.dbscheme

Lines changed: 2618 additions & 0 deletions
Large diffs are not rendered by default.

swift/downgrades/44e36e15e90bc1535964d9b86b3cd06a8b0d26e3/swift.dbscheme

Lines changed: 2630 additions & 0 deletions
Large diffs are not rendered by default.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
description: Revert removing `getInterpolationCountExpr` and `getLiteralCapacityExpr` from `InterpolatedStringLiteralExpr`
2+
compatibility: backwards

swift/extractor/translators/ExprTranslator.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ codeql::InterpolatedStringLiteralExpr ExprTranslator::translateInterpolatedStrin
6161
const swift::InterpolatedStringLiteralExpr& expr) {
6262
auto entry = createExprEntry(expr);
6363
entry.interpolation_expr = dispatcher.fetchOptionalLabel(expr.getInterpolationExpr());
64-
// TODO we should be extracting getInterpolationCount and getLiteralCapacity directly to ints
65-
// these expressions here are just an internal thing, the ints are actually directly available
66-
entry.interpolation_count_expr = dispatcher.fetchOptionalLabel(expr.getInterpolationCountExpr());
67-
entry.literal_capacity_expr = dispatcher.fetchOptionalLabel(expr.getLiteralCapacityExpr());
6864
entry.appending_expr = dispatcher.fetchOptionalLabel(expr.getAppendingExpr());
6965
return entry;
7066
}

swift/ql/.generated.list

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swift/ql/lib/codeql/swift/generated/ParentChild.qll

Lines changed: 2 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swift/ql/lib/codeql/swift/generated/Raw.qll

Lines changed: 0 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swift/ql/lib/codeql/swift/generated/expr/InterpolatedStringLiteralExpr.qll

Lines changed: 0 additions & 57 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swift/ql/lib/swift.dbscheme

Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
class Element extends @element {
2+
string toString() { none() }
3+
}
4+
5+
from Element i, string value
6+
where
7+
integer_literal_exprs(i, value) and
8+
not exists(Element interpolated |
9+
interpolated_string_literal_expr_interpolation_count_exprs(interpolated, i)
10+
or
11+
interpolated_string_literal_expr_literal_capacity_exprs(interpolated, i)
12+
)
13+
select i, value

0 commit comments

Comments
 (0)