Skip to content

Commit 0c99b36

Browse files
committed
C++: remove false negative comments in swap tests
1 parent 1c9b6f0 commit 0c99b36

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cpp/ql/test/library-tests/dataflow/taint-tests/swap1.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ void test_copy_assignment_operator()
6262

6363
y = x;
6464

65-
sink(y.data1); // tainted [FALSE NEGATIVE in IR]
65+
sink(y.data1); // tainted
6666
sink(x.data1); // tainted
6767

6868
IntWrapper::Class z1, z2;
@@ -86,7 +86,7 @@ void test_move_assignment_operator()
8686

8787
y = std::move(x);
8888

89-
sink(y.data1); // tainted [FALSE NEGATIVE in IR]
89+
sink(y.data1); // tainted
9090
sink(x.data1); // tainted
9191
}
9292

@@ -99,5 +99,5 @@ void test_move_constructor()
9999

100100
IntWrapper::Class move_to(std::move(move_from));
101101

102-
sink(move_to.data1); // tainted [FALSE NEGATIVE in IR]
102+
sink(move_to.data1); // tainted
103103
}

cpp/ql/test/library-tests/dataflow/taint-tests/swap2.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ void test_copy_assignment_operator()
6262

6363
y = x;
6464

65-
sink(y.data1); // tainted [FALSE NEGATIVE in IR]
65+
sink(y.data1); // tainted
6666
sink(x.data1); // tainted
6767

6868
IntWrapper::Class z1, z2;
@@ -86,7 +86,7 @@ void test_move_assignment_operator()
8686

8787
y = std::move(x);
8888

89-
sink(y.data1); // tainted [FALSE NEGATIVE in IR]
89+
sink(y.data1); // tainted
9090
sink(x.data1); // tainted
9191
}
9292

@@ -99,5 +99,5 @@ void test_move_constructor()
9999

100100
IntWrapper::Class move_to(std::move(move_from));
101101

102-
sink(move_to.data1); // tainted [FALSE NEGATIVE in IR]
102+
sink(move_to.data1); // tainted
103103
}

0 commit comments

Comments
 (0)