Skip to content

Commit 15c2ccb

Browse files
committed
Python: ignore experimental for now
1 parent 9dfd1cc commit 15c2ccb

File tree

3 files changed

+0
-30
lines changed

3 files changed

+0
-30
lines changed

python/ql/src/experimental/Security/CWE-208/TimingAttackAgainstHash/PossibleTimingAttackAgainstHash.ql

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,6 @@ private module PossibleTimingAttackAgainstHashConfig implements DataFlow::Config
2626
predicate isSource(DataFlow::Node source) { source instanceof ProduceCryptoCall }
2727

2828
predicate isSink(DataFlow::Node sink) { sink instanceof NonConstantTimeComparisonSink }
29-
30-
predicate observeDiffInformedIncrementalMode() {
31-
// TODO(diff-informed): Manually verify if config can be diff-informed.
32-
// ql/src/experimental/Security/CWE-208/TimingAttackAgainstHash/PossibleTimingAttackAgainstHash.ql:41: Column 5 selects source.getResultType
33-
none()
34-
}
3529
}
3630

3731
module PossibleTimingAttackAgainstHashFlow =

python/ql/src/experimental/Security/CWE-208/TimingAttackAgainstHash/TimingAttackAgainstHash.ql

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ private module TimingAttackAgainstHashConfig implements DataFlow::ConfigSig {
2525
predicate isSource(DataFlow::Node source) { source instanceof ProduceCryptoCall }
2626

2727
predicate isSink(DataFlow::Node sink) { sink instanceof NonConstantTimeComparisonSink }
28-
29-
predicate observeDiffInformedIncrementalMode() {
30-
// TODO(diff-informed): Manually verify if config can be diff-informed.
31-
// ql/src/experimental/Security/CWE-208/TimingAttackAgainstHash/TimingAttackAgainstHash.ql:39: Column 5 selects source.getResultType
32-
none()
33-
}
3428
}
3529

3630
module TimingAttackAgainstHashFlow = TaintTracking::Global<TimingAttackAgainstHashConfig>;

python/ql/src/experimental/semmle/python/security/TimingAttack.qll

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -271,12 +271,6 @@ module UserInputSecretConfig implements DataFlow::ConfigSig {
271271
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
272272

273273
predicate isSink(DataFlow::Node sink) { sink.asExpr() instanceof CredentialExpr }
274-
275-
predicate observeDiffInformedIncrementalMode() {
276-
// TODO(diff-informed): Manually verify if config can be diff-informed.
277-
// ql/src/experimental/semmle/python/security/TimingAttack.qll:176: Flow call outside 'select' clause
278-
none()
279-
}
280274
}
281275

282276
module UserInputSecretFlow = TaintTracking::Global<UserInputSecretConfig>;
@@ -294,12 +288,6 @@ module UserInputInComparisonConfig implements DataFlow::ConfigSig {
294288
sink.asExpr() = [left, right]
295289
)
296290
}
297-
298-
predicate observeDiffInformedIncrementalMode() {
299-
// TODO(diff-informed): Manually verify if config can be diff-informed.
300-
// ql/src/experimental/semmle/python/security/TimingAttack.qll:165: Flow call outside 'select' clause
301-
none()
302-
}
303291
}
304292

305293
module UserInputInComparisonFlow = TaintTracking::Global<UserInputInComparisonConfig>;
@@ -316,12 +304,6 @@ private module ExcludeLenFuncConfig implements DataFlow::ConfigSig {
316304
sink.asExpr() = call.getArg(0)
317305
)
318306
}
319-
320-
predicate observeDiffInformedIncrementalMode() {
321-
// TODO(diff-informed): Manually verify if config can be diff-informed.
322-
// ql/src/experimental/semmle/python/security/TimingAttack.qll:347: Flow call outside 'select' clause
323-
none()
324-
}
325307
}
326308

327309
module ExcludeLenFuncFlow = TaintTracking::Global<ExcludeLenFuncConfig>;

0 commit comments

Comments
 (0)