Skip to content

Commit 166d523

Browse files
authored
Apply suggestions from code review
1 parent e6198ba commit 166d523

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

go/ql/lib/ext/github.com.couchbase.gocb.model.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ extensions:
8282
- ["group:gocb2", "AnalyticsResultRaw", True, "NextBytes", "", "", "Argument[receiver]", "ReturnValue", "taint", "manual"]
8383
- ["group:gocb2", "GetResult", True, "Content", "", "", "Argument[receiver]", "Argument[0]", "taint", "manual"]
8484
- ["group:gocb2", "LookupInResult", True, "ContentAt", "", "", "Argument[receiver]", "Argument[1]", "taint", "manual"]
85-
- ["group:gocb2", "LookupInReplicaResult", True, "ContentAt", "", "", "Argument[receiver]", "Argument[1]", "taint", "manual"]
8685
- ["group:gocb2", "LookupInAllReplicasResult", True, "Next", "", "", "Argument[receiver]", "ReturnValue", "taint", "manual"]
8786
- ["group:gocb2", "MutateInResult", True, "ContentAt", "", "", "Argument[receiver]", "Argument[1]", "taint", "manual"]
8887
- ["group:gocb2", "QueryResult", True, "One", "", "", "Argument[receiver]", "Argument[0]", "taint", "manual"]

go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/database/test_couchbase_gocb_v1.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,6 @@ func test_couchbase_gocb_v1_Cluster(cluster *gocb.Cluster, aq *gocb.AnalyticsQue
5050
return
5151
}
5252

53-
sink(r3) // $ hasTaintFlow="r3"
53+
hit := r3.Hits()[0]
54+
sink(hit) // $ hasTaintFlow="hit"
5455
}

go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/database/test_couchbase_gocb_v2.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func test_couchbase_gocb_v2_Cluster(cluster *gocb.Cluster) {
4747
}
4848

4949
func test_couchbase_gocb_v2_Scope(scope *gocb.Scope) {
50-
r1, err := scope.Query("SELECT * FROM `travel-sample`", nil) // $ source
50+
r1, err := scope.AnalyticsQuery("SELECT * FROM `travel-sample`", nil) // $ source
5151

5252
if err != nil {
5353
return

go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/database/vendor/github.com/couchbase/gocb/stub.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)