Skip to content

Commit 1e08105

Browse files
committed
less duplicated headers in the sql-injection samples
1 parent 9882078 commit 1e08105

File tree

3 files changed

+2
-24
lines changed

3 files changed

+2
-24
lines changed

javascript/ql/src/Security/CWE-089/SqlInjection.inc.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,14 @@ to ensure that the user input is interpreted as a literal value
8080
and not as a query object:
8181
</p>
8282

83-
<sample src="examples/NoSqlInjectionFix2.js" />
83+
<sample src="examples/NoSqlInjectionFix.js" />
8484

8585
<p>
8686
Alternatively check that the user input is a
8787
literal value and not a query object before using it:
8888
</p>
8989

90-
<sample src="examples/NoSqlInjectionFix.js" />
90+
<sample src="examples/NoSqlInjectionFix2.js" />
9191
</example>
9292

9393
<references>

javascript/ql/src/Security/CWE-089/examples/NoSqlInjectionFix.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,3 @@
1-
const express = require("express");
2-
const mongoose = require("mongoose");
3-
const Todo = mongoose.model(
4-
"Todo",
5-
new mongoose.Schema({ text: { type: String } }, { timestamps: true })
6-
);
7-
8-
const app = express();
9-
app.use(express.json());
10-
app.use(express.urlencoded({ extended: false }));
11-
121
app.delete("/api/delete", async (req, res) => {
132
let id = req.body.id;
143
await Todo.deleteOne({ _id: { $eq: id } }); // GOOD: using $eq operator for the comparison

javascript/ql/src/Security/CWE-089/examples/NoSqlInjectionFix2.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,3 @@
1-
const express = require("express");
2-
const mongoose = require("mongoose");
3-
const Todo = mongoose.model(
4-
"Todo",
5-
new mongoose.Schema({ text: { type: String } }, { timestamps: true })
6-
);
7-
8-
const app = express();
9-
app.use(express.json());
10-
app.use(express.urlencoded({ extended: false }));
11-
121
app.delete("/api/delete", async (req, res) => {
132
let id = req.body.id;
143
if (typeof id !== "string") {

0 commit comments

Comments
 (0)