Skip to content

Commit 1f95fa1

Browse files
committed
Java: Fix comment re. neutrals and WithoutElement.
The remove methods should not have been in this section, as they're plain neutrals.
1 parent 6f74387 commit 1f95fa1

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

java/ql/lib/ext/java.util.model.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@ extensions:
430430
- ["java.util", "Collection", "contains", "(Object)", "summary", "manual"]
431431
- ["java.util", "Collection", "containsAll", "(Collection)", "summary", "manual"]
432432
- ["java.util", "Collection", "isEmpty", "()", "summary", "manual"]
433+
- ["java.util", "Collection", "removeIf", "(Predicate)", "summary", "manual"]
433434
- ["java.util", "Collection", "size", "()", "summary", "manual"]
434435
- ["java.util", "Collections", "emptyList", "()", "summary", "manual"]
435436
- ["java.util", "Collections", "emptyMap", "()", "summary", "manual"]
@@ -451,12 +452,14 @@ extensions:
451452
- ["java.util", "HashMap", "size", "()", "summary", "manual"]
452453
- ["java.util", "HashSet", "HashSet", "(int)", "summary", "manual"]
453454
- ["java.util", "Iterator", "hasNext", "()", "summary", "manual"]
455+
- ["java.util", "Iterator", "remove", "()", "summary", "manual"]
454456
- ["java.util", "List", "contains", "(Object)", "summary", "manual"]
455457
- ["java.util", "List", "equals", "(Object)", "summary", "manual"]
456458
- ["java.util", "List", "hashCode", "()", "summary", "manual"]
457459
- ["java.util", "List", "indexOf", "(Object)", "summary", "manual"]
458460
- ["java.util", "List", "isEmpty", "()", "summary", "manual"]
459461
- ["java.util", "List", "of", "()", "summary", "manual"]
462+
- ["java.util", "List", "remove", "(Object)", "summary", "manual"]
460463
- ["java.util", "List", "sort", "(Comparator)", "summary", "manual"]
461464
- ["java.util", "List", "size", "()", "summary", "manual"]
462465
- ["java.util", "Locale$Builder", "addUnicodeLocaleAttribute", "(String)", "summary", "df-manual"]
@@ -535,6 +538,8 @@ extensions:
535538
- ["java.util", "Scanner", "locale", "()", "summary", "df-manual"]
536539
- ["java.util", "Set", "contains", "(Object)", "summary", "manual"]
537540
- ["java.util", "Set", "isEmpty", "()", "summary", "manual"]
541+
- ["java.util", "Set", "remove", "(Object)", "summary", "manual"]
542+
- ["java.util", "Set", "removeAll", "(Collection)", "summary", "manual"]
538543
- ["java.util", "Set", "size", "()", "summary", "manual"]
539544
- ["java.util", "TreeMap", "TreeMap", "(Comparator)", "summary", "df-manual"]
540545
- ["java.util", "TreeSet", "TreeSet", "(Comparator)", "summary", "df-manual"]
@@ -545,14 +550,8 @@ extensions:
545550
- ["java.util", "TimeZone", "getTimeZone", "(String)", "summary", "manual"]
546551
- ["java.util", "Vector", "size", "()", "summary", "manual"]
547552

548-
# The below APIs are currently being stored as neutral models since `WithoutElement` has not yet been implemented for Java.
549-
# When `WithoutElement` is implemented, these should be changed to summary models of the form `Argument[this].WithoutElement -> Argument[this]`.
550-
- ["java.util", "Collection", "removeIf", "(Predicate)", "summary", "manual"]
551-
- ["java.util", "Iterator", "remove", "()", "summary", "manual"]
552-
- ["java.util", "List", "remove", "(Object)", "summary", "manual"]
553+
# The below API is currently being stored as neutral models since `WithoutElement` does not yet have a counterpart for MapValue/MapKey.
553554
- ["java.util", "Map", "clear", "()", "summary", "manual"]
554-
- ["java.util", "Set", "remove", "(Object)", "summary", "manual"]
555-
- ["java.util", "Set", "removeAll", "(Collection)", "summary", "manual"]
556555

557556
# The below APIs have numeric flow and are currently being stored as neutral models.
558557
# These may be changed to summary models with kinds "value-numeric" and "taint-numeric" (or similar) in the future.

0 commit comments

Comments
 (0)