Dataflow: Prevent bad join.

aschackmull · aschackmull · commit 20bb6314566b · 2024-02-26T13:45:19.000+01:00
diff --git a/shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll b/shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll
@@ -1081,8 +1081,8 @@ module Make<DF::InputSig DataFlowLang, InputSig<DataFlowLang> Input> {
           SummaryComponentStack outputContents
         |
           summary(c, inputContents, outputContents, preservesValue) and
-          pred = summaryNodeInputState(c, inputContents) and
-          succ = summaryNodeOutputState(c, outputContents)
+          pred = summaryNodeInputState(pragma[only_bind_into](c), inputContents) and
+          succ = summaryNodeOutputState(pragma[only_bind_into](c), outputContents)
         |
           preservesValue = true
           or

Original file line number	Diff line number	Diff line change
`@@ -1081,8 +1081,8 @@ module Make<DF::InputSig DataFlowLang, InputSig<DataFlowLang> Input> {`
`1081`	`1081`	`SummaryComponentStack outputContents`
`1082`	`1082`	`\|`
`1083`	`1083`	`summary(c, inputContents, outputContents, preservesValue) and`
`1084`		`- pred = summaryNodeInputState(c, inputContents) and`
`1085`		`- succ = summaryNodeOutputState(c, outputContents)`
	`1084`	`+ pred = summaryNodeInputState(pragma[only_bind_into](c), inputContents) and`
	`1085`	`+ succ = summaryNodeOutputState(pragma[only_bind_into](c), outputContents)`
`1086`	`1086`	`\|`
`1087`	`1087`	`preservesValue = true`
`1088`	`1088`	`or`