Skip to content

Commit 20df63f

Browse files
committed
C++: Respond to review comments.
1 parent 5e14b5c commit 20df63f

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/RangeAnalysisStage.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1108,7 +1108,7 @@ module RangeStage<
11081108
or
11091109
exists(D::Delta dLeft, D::Delta dRight, boolean fbeLeft, boolean fbeRight |
11101110
boundedSubOperandLeft(e, upper, b, dLeft, fbeLeft, origdelta, reason) and
1111-
boundedSubOperandRight(e, upper, dRight, fbeRight, _, _) and
1111+
boundedSubOperandRight(e, upper, dRight, fbeRight) and
11121112
// when `upper` is `true` we have:
11131113
// left <= b + dLeft
11141114
// right >= 0 + dRight
@@ -1210,13 +1210,12 @@ module RangeStage<
12101210
*/
12111211
pragma[nomagic]
12121212
private predicate boundedSubOperandRight(
1213-
SemSubExpr sub, boolean upper, D::Delta delta, boolean fromBackEdge, D::Delta origdelta,
1214-
SemReason reason
1213+
SemSubExpr sub, boolean upper, D::Delta delta, boolean fromBackEdge
12151214
) {
12161215
// `semValueFlowStep` already handles the case where one of the operands is a constant.
12171216
not semValueFlowStep(sub, _, _) and
1218-
bounded(sub.getRightOperand(), any(SemZeroBound zb), delta, upper.booleanNot(), fromBackEdge,
1219-
origdelta, reason)
1217+
bounded(sub.getRightOperand(), any(SemZeroBound zb), delta, upper.booleanNot(), fromBackEdge, _,
1218+
_)
12201219
}
12211220

12221221
pragma[nomagic]

0 commit comments

Comments
 (0)