Add comment noting that a Method or Field might have multiple SourceOrSinkElements

smowton · owen-mc · commit 20e8d4886974 · 2024-11-11T23:43:45.000Z
diff --git a/go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImpl.qll b/go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImpl.qll
@@ -149,6 +149,9 @@ module SourceSinkInterpretationInput implements
     )
   }
 
+  // Note that due to embedding, which is currently implemented via some Methods
+  // or Fields having multiple qualified names, a given Method or Field is liable
+  // to have more than one SourceOrSinkElement, one for each of the names it claims.
   private newtype TSourceOrSinkElement =
     TMethodEntityElement(Method m, string pkg, string type, boolean subtypes) {
       m.hasQualifiedName(pkg, type, _) and subtypes = [true, false]

Original file line number	Diff line number	Diff line change
`@@ -149,6 +149,9 @@ module SourceSinkInterpretationInput implements`
`149`	`149`	`)`
`150`	`150`	`}`
`151`	`151`
	`152`	`+ // Note that due to embedding, which is currently implemented via some Methods`
	`153`	`+ // or Fields having multiple qualified names, a given Method or Field is liable`
	`154`	`+ // to have more than one SourceOrSinkElement, one for each of the names it claims.`
`152`	`155`	`private newtype TSourceOrSinkElement =`
`153`	`156`	`TMethodEntityElement(Method m, string pkg, string type, boolean subtypes) {`
`154`	`157`	`m.hasQualifiedName(pkg, type, _) and subtypes = [true, false]`