Skip to content

Commit 2d3fed9

Browse files
committed
Accept intended test result changes
1 parent 17077f3 commit 2d3fed9

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

go/ql/test/library-tests/semmle/go/dataflow/ExternalFlowVarArgs/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func main() {
2424
sink(test.FunctionWithParameter(sSlice[1])) // $ taintflow dataflow
2525
sink(test.FunctionWithSliceParameter(sSlice)) // $ taintflow dataflow
2626
sink(test.FunctionWithVarArgsParameter(sSlice...)) // $ taintflow dataflow
27-
sink(test.FunctionWithVarArgsParameter(s0, s1)) // $ MISSING: taintflow dataflow
27+
sink(test.FunctionWithVarArgsParameter(s0, s1)) // $ taintflow dataflow
2828

2929
sliceOfStructs := []test.A{{Field: source()}}
3030
sink(sliceOfStructs[0].Field) // $ taintflow dataflow
@@ -34,5 +34,5 @@ func main() {
3434
aSlice := []test.A{a0, a1}
3535
sink(test.FunctionWithSliceOfStructsParameter(aSlice)) // $ taintflow dataflow
3636
sink(test.FunctionWithVarArgsOfStructsParameter(aSlice...)) // $ taintflow dataflow
37-
sink(test.FunctionWithVarArgsOfStructsParameter(a0, a1)) // $ MISSING: taintflow dataflow
37+
sink(test.FunctionWithVarArgsOfStructsParameter(a0, a1)) // $ taintflow dataflow
3838
}
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
| main.go:7:2:7:25 | call to Println | 0 | main.go:7:14:7:24 | ...+... |
2-
| main.go:10:2:10:19 | call to Println | 0 | main.go:10:14:10:18 | ...+... |
1+
| main.go:7:2:7:25 | call to Println | 0 | main.go:7:2:7:25 | []type{args} |
2+
| main.go:10:2:10:19 | call to Println | 0 | main.go:10:2:10:19 | []type{args} |
33
| main.go:14:8:14:24 | call to make | 0 | main.go:14:23:14:23 | 1 |
4-
| main.go:16:2:16:26 | call to Println | 0 | main.go:16:14:16:15 | ss |
5-
| main.go:16:2:16:26 | call to Println | 1 | main.go:16:18:16:18 | 0 |
6-
| main.go:16:2:16:26 | call to Println | 2 | main.go:16:21:16:25 | index expression |
4+
| main.go:16:2:16:26 | call to Println | 0 | main.go:16:2:16:26 | []type{args} |

go/ql/test/library-tests/semmle/go/dataflow/VarArgs/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func main() {
3636
sSlice := []string{s0, s1}
3737
sink(functionWithSliceParameter(sSlice)) // $ taintflow dataflow
3838
sink(functionWithVarArgsParameter(sSlice...)) // $ taintflow dataflow
39-
sink(functionWithVarArgsParameter(s0, s1)) // $ MISSING: taintflow dataflow
39+
sink(functionWithVarArgsParameter(s0, s1)) // $ taintflow dataflow
4040

4141
sliceOfStructs := []A{{f: source()}}
4242
sink(sliceOfStructs[0].f) // $ taintflow dataflow
@@ -46,5 +46,5 @@ func main() {
4646
aSlice := []A{a0, a1}
4747
sink(functionWithSliceOfStructsParameter(aSlice)) // $ taintflow dataflow
4848
sink(functionWithVarArgsOfStructsParameter(aSlice...)) // $ taintflow dataflow
49-
sink(functionWithVarArgsOfStructsParameter(a0, a1)) // $ MISSING: taintflow dataflow
49+
sink(functionWithVarArgsOfStructsParameter(a0, a1)) // $ taintflow dataflow
5050
}

0 commit comments

Comments
 (0)