Skip to content

Commit 3c4d938

Browse files
atorralbaasgerf
andcommitted
Apply code review suggestions.
Co-authored-by: Asger F <[email protected]>
1 parent 433fc68 commit 3c4d938

File tree

6 files changed

+18
-22
lines changed

6 files changed

+18
-22
lines changed

csharp/ql/src/Security Features/CWE-022/ZipSlip.qhelp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33
"qhelp.dtd">
44
<qhelp>
55
<overview>
6-
<p>Accessing filesystem paths built from the name of an archive entry without validating that the
7-
destination file path is within the destination directory can allow an attacker to access
8-
unexpected resources, due to the possible presence of directory traversal elements (<code>..</code>) in
9-
archive paths.</p>
6+
<p>Extracting files from a malicious zip file, or similar type of archive,
7+
is at risk of directory traversal attacks if filenames from the archive are
8+
not properly validated.</p>
109

1110
<p>Zip archives contain archive entries representing each file in the archive. These entries
1211
include a file path for the entry, but these file paths are not restricted and may contain

go/ql/src/Security/CWE-022/ZipSlip.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55

66
<overview>
77
<p>
8-
Accessing filesystem paths built from the name of an archive entry without validating that the
9-
destination file path is within the destination directory can allow an attacker to access
10-
unexpected resources, due to the possible presence of directory traversal elements (<code>..</code>) in
8+
Extracting files from a malicious zip file, or similar type of archive,
9+
is at risk of directory traversal attacks if filenames from the archive are
10+
not properly validated.
1111
archive paths.
1212
</p>
1313

java/ql/src/Security/CWE/CWE-022/ZipSlip.qhelp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33
"qhelp.dtd">
44
<qhelp>
55
<overview>
6-
<p>Accessing filesystem paths built from the name of an archive entry without validating that the
7-
destination file path is within the destination directory can allow an attacker to access
8-
unexpected resources, due to the possible presence of directory traversal elements (<code>..</code>) in
9-
archive paths.</p>
6+
<p>Extracting files from a malicious zip file, or similar type of archive,
7+
is at risk of directory traversal attacks if filenames from the archive are
8+
not properly validated.</p>
109

1110
<p>Zip archives contain archive entries representing each file in the archive. These entries
1211
include a file path for the entry, but these file paths are not restricted and may contain

javascript/ql/src/Security/CWE-022/ZipSlip.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
<qhelp>
55

66
<overview>
7-
<p>Accessing filesystem paths built from the name of an archive entry without validating that the
8-
destination file path is within the destination directory can allow an attacker to access
9-
unexpected resources, due to the possible presence of directory traversal elements (<code>..</code>) in
7+
<p>Extracting files from a malicious zip file, or similar type of archive,
8+
is at risk of directory traversal attacks if filenames from the archive are
9+
not properly validated.
1010
archive paths.</p>
1111

1212
<p>Zip archives contain archive entries representing each file in the archive. These entries

python/ql/src/experimental/Security/CWE-022/ZipSlip.qhelp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
<qhelp>
55

66
<overview>
7-
<p>Accessing filesystem paths built from the name of an archive entry without validating that the
8-
destination file path is within the destination directory can allow an attacker to access
9-
unexpected resources, due to the possible presence of directory traversal elements (<code>..</code>) in
10-
archive paths.</p>
7+
<p>Extracting files from a malicious zip file, or similar type of archive,
8+
is at risk of directory traversal attacks if filenames from the archive are
9+
not properly validated.</p>
1110

1211
<p>Zip archives contain archive entries representing each file in the archive. These entries
1312
include a file path for the entry, but these file paths are not restricted and may contain

ruby/ql/src/experimental/cwe-022-zipslip/ZipSlip.qhelp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
<qhelp>
55

66
<overview>
7-
<p>Accessing filesystem paths built from the name of an archive entry without validating that the
8-
destination file path is within the destination directory can allow an attacker to access
9-
unexpected resources, due to the possible presence of directory traversal elements (<code>..</code>) in
10-
archive paths.</p>
7+
<p>Extracting files from a malicious zip file, or similar type of archive,
8+
is at risk of directory traversal attacks if filenames from the archive are
9+
not properly validated.</p>
1110

1211
<p>Tar archives contain archive entries representing each file in the archive. These entries
1312
include a file path for the entry, but these file paths are not restricted and may contain

0 commit comments

Comments
 (0)