JS: Remove unimportant TODO

asgerf · asgerf · commit 3def8ecdeea9 · 2025-01-09T09:43:03.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll b/javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll
@@ -1401,7 +1401,7 @@ predicate readStep(Node node1, ContentSet c, Node node2) {
     // shift known array indices
     c.asSingleton().asArrayIndex() = content.asArrayIndex() + restIndex
     or
-    content.isUnknownArrayElement() and // TODO: don't read unknown array elements from static array
+    content.isUnknownArrayElement() and
     c = ContentSet::arrayElementUnknown()
   )
   or

Original file line number	Diff line number	Diff line change
`@@ -1401,7 +1401,7 @@ predicate readStep(Node node1, ContentSet c, Node node2) {`
`1401`	`1401`	`// shift known array indices`
`1402`	`1402`	`c.asSingleton().asArrayIndex() = content.asArrayIndex() + restIndex`
`1403`	`1403`	`or`
`1404`		`- content.isUnknownArrayElement() and // TODO: don't read unknown array elements from static array`
	`1404`	`+ content.isUnknownArrayElement() and`
`1405`	`1405`	`c = ContentSet::arrayElementUnknown()`
`1406`	`1406`	`)`
`1407`	`1407`	`or`