Skip to content

Commit 3f36d32

Browse files
committed
Fix singleton set literal
1 parent a524735 commit 3f36d32

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

ruby/ql/lib/codeql/ruby/frameworks/Ldap.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ module NetLdap {
2929

3030
/** A call that establishes a LDAP Connection */
3131
private class NetLdapConnection extends DataFlow::CallNode {
32-
NetLdapConnection() { this in [ldap().getAnInstantiation(), ldap().getAMethodCall(["open"])] }
32+
NetLdapConnection() { this in [ldap().getAnInstantiation(), ldap().getAMethodCall("open")] }
3333
}
3434

3535
/** A call that constructs a LDAP query */
3636
private class NetLdapFilter extends LdapConstruction::Range, DataFlow::CallNode {
37-
NetLdapFilter() { this = any(ldap().getMember("Filter").getAMethodCall(["eq"])) }
37+
NetLdapFilter() { this = any(ldap().getMember("Filter").getAMethodCall("eq")) }
3838

3939
override DataFlow::Node getQuery() { result = this.getArgument([0, 1]) }
4040
}

ruby/ql/lib/codeql/ruby/security/LdapInjectionCustomizations.qll

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ module LdapInjection {
3434
exists(DataFlow::CallNode filterCall |
3535
(
3636
filterCall =
37-
API::getTopLevelMember("Net").getMember("LDAP").getMember("Filter").getAMethodCall(["eq"]) or
38-
filterCall.getMethodName() = ["[]"]
37+
API::getTopLevelMember("Net").getMember("LDAP").getMember("Filter").getAMethodCall("eq") or
38+
filterCall.getMethodName() = "[]"
3939
) and
4040
n1 = filterCall.getArgument([0, 1]) and
4141
n2 = filterCall
@@ -64,5 +64,6 @@ module LdapInjection {
6464
* sanitizer-guard.
6565
*/
6666
private class StringConstArrayInclusionCallAsSanitizer extends Sanitizer,
67-
StringConstArrayInclusionCallBarrier { }
67+
StringConstArrayInclusionCallBarrier
68+
{ }
6869
}

0 commit comments

Comments
 (0)