Skip to content

Commit 434fa20

Browse files
committed
Refactor to using ThreatModelFlowSource
1 parent 1086abc commit 434fa20

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,14 @@ deprecated class UntrustedDataToExternalApiConfig extends TaintTracking::Configu
9797
override predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }
9898
}
9999

100-
/** A configuration for tracking flow from `RemoteFlowSource`s to `ExternalApiDataNode`s. */
100+
/** A configuration for tracking flow from `ThreatModelFlowSource`s to `ExternalApiDataNode`s. */
101101
private module RemoteSourceToExternalApiConfig implements DataFlow::ConfigSig {
102-
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
102+
predicate isSource(DataFlow::Node source) { source instanceof ThreatModelFlowSource }
103103

104104
predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }
105105
}
106106

107-
/** A module for tracking flow from `RemoteFlowSource`s to `ExternalApiDataNode`s. */
107+
/** A module for tracking flow from `ThreatModelFlowSource`s to `ExternalApiDataNode`s. */
108108
module RemoteSourceToExternalApi = TaintTracking::Global<RemoteSourceToExternalApiConfig>;
109109

110110
/** A node representing untrusted data being passed to an external API. */

csharp/ql/src/Security Features/CWE-091/XMLInjection.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@
1212
*/
1313

1414
import csharp
15-
import semmle.code.csharp.security.dataflow.flowsources.Remote
15+
import semmle.code.csharp.security.dataflow.flowsources.FlowSources
1616
import semmle.code.csharp.frameworks.system.Xml
1717
import XmlInjection::PathGraph
1818

1919
/**
2020
* A taint-tracking configuration for untrusted user input used in XML.
2121
*/
2222
module XmlInjectionConfig implements DataFlow::ConfigSig {
23-
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
23+
predicate isSource(DataFlow::Node source) { source instanceof ThreatModelFlowSource }
2424

2525
predicate isSink(DataFlow::Node sink) {
2626
exists(MethodCall mc |

0 commit comments

Comments
 (0)