JS: Accept fixed FP flow.

aschackmull · aschackmull · commit 449150e6b56f · 2025-02-25T10:42:21.000+01:00
diff --git a/javascript/ql/test/library-tests/TripleDot/useuse.js b/javascript/ql/test/library-tests/TripleDot/useuse.js
@@ -165,7 +165,7 @@ function t9() { // same as t8 but with a SanitizerGuard that isn't just a variab
         if (typeof obj === "undefined" || typeof obj === "undefined") {
             // The shared SSA library expects short-circuiting operators be pre-order in the CFG,
             // but in JS they are post-order (as per evaluation order).
-            sink(obj.field); // $ SPURIOUS: hasTaintFlow=t9.1
+            sink(obj.field);
         } else {
             sink(obj.field); // $ hasTaintFlow=t9.1
         }

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ function t9() { // same as t8 but with a SanitizerGuard that isn't just a variab`
`165`	`165`	`if (typeof obj === "undefined" \|\| typeof obj === "undefined") {`
`166`	`166`	`// The shared SSA library expects short-circuiting operators be pre-order in the CFG,`
`167`	`167`	`// but in JS they are post-order (as per evaluation order).`
`168`		`- sink(obj.field); // $ SPURIOUS: hasTaintFlow=t9.1`
	`168`	`+ sink(obj.field);`
`169`	`169`	`} else {`
`170`	`170`	`sink(obj.field); // $ hasTaintFlow=t9.1`
`171`	`171`	`}`