Skip to content

Commit 46fc1fd

Browse files
committed
Swift: Suggestions from review.
1 parent 15c49ee commit 46fc1fd

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

swift/ql/lib/codeql/swift/regex/Regex.qll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ abstract class RegexPatternSource extends DataFlow::Node {
3434
* a `Regex`. This is a simple wrapper to make that happen.
3535
*/
3636
private class RegexFromRegexPatternSource extends RegExp {
37-
RegexPatternSource node;
38-
39-
RegexFromRegexPatternSource() { this = node.asExpr() }
37+
RegexFromRegexPatternSource() { this = any(RegexPatternSource node).asExpr() }
4038
}
4139

4240
/**

swift/ql/lib/codeql/swift/security/regex/HostnameRegex.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ private import codeql.regex.HostnameRegexp as Shared
1212
/**
1313
* An implementation of the signature that allows the Hostname analysis to run.
1414
*/
15-
module Impl implements Shared::HostnameRegexpSig<TreeImpl> {
15+
private module Impl implements Shared::HostnameRegexpSig<TreeImpl> {
1616
class DataFlowNode = DataFlow::Node;
1717

1818
class RegExpPatternSource = Regex::RegexPatternSource;

0 commit comments

Comments
 (0)