Small QL improvement

owen-mc · owen-mc · commit 489a87fbae4a · 2025-01-20T16:22:37.000Z
diff --git a/go/ql/lib/semmle/go/frameworks/GinCors.qll b/go/ql/lib/semmle/go/frameworks/GinCors.qll
@@ -128,7 +128,7 @@ module GinCors {
 
     GinConfig() {
       this = v.getBaseVariable().getSourceVariable() and
-      exists(Type t | t.hasQualifiedName(packagePath(), "Config") | v.getType() = t)
+      v.getType().hasQualifiedName(packagePath(), "Config")
     }
 
     /**
diff --git a/go/ql/lib/semmle/go/frameworks/RsCors.qll b/go/ql/lib/semmle/go/frameworks/RsCors.qll
@@ -173,7 +173,7 @@ module RsCors {
 
     RsOptions() {
       this = v.getBaseVariable().getSourceVariable() and
-      exists(Type t | t.hasQualifiedName(packagePath(), "Options") | v.getType() = t)
+      v.getType().hasQualifiedName(packagePath(), "Options")
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ module GinCors {`
`128`	`128`
`129`	`129`	`GinConfig() {`
`130`	`130`	`this = v.getBaseVariable().getSourceVariable() and`
`131`		`- exists(Type t \| t.hasQualifiedName(packagePath(), "Config") \| v.getType() = t)`
	`131`	`+ v.getType().hasQualifiedName(packagePath(), "Config")`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ module RsCors {`
`173`	`173`
`174`	`174`	`RsOptions() {`
`175`	`175`	`this = v.getBaseVariable().getSourceVariable() and`
`176`		`- exists(Type t \| t.hasQualifiedName(packagePath(), "Options") \| v.getType() = t)`
	`176`	`+ v.getType().hasQualifiedName(packagePath(), "Options")`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`/**`