Skip to content

Commit 4a2c025

Browse files
MathiasVPMathiasVP
committed
C#: Accept test changes.
1 parent 041df78 commit 4a2c025

File tree

2 files changed

+63
-3
lines changed

2 files changed

+63
-3
lines changed

‎csharp/ql/test/library-tests/dataflow/fields/FieldFlow.expected

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1162,6 +1162,30 @@ edges
11621162
| K.cs:8:22:8:22 | access to local variable o : String | K.cs:8:9:8:15 | [post] access to field Strings : String[] [element] : String | provenance | |
11631163
| K.cs:13:14:13:20 | access to field Strings : String[] [element] : String | K.cs:13:14:13:23 | access to array element | provenance | |
11641164
| K.cs:13:14:13:20 | access to field Strings : String[] [element] : String | K.cs:13:14:13:23 | access to array element | provenance | |
1165+
| L.cs:13:9:13:10 | [post] access to local variable d1 : Object [dynamic property f1] : String | L.cs:14:14:14:15 | access to local variable d1 : Object [dynamic property f1] : String | provenance | |
1166+
| L.cs:13:9:13:10 | [post] access to local variable d1 : Object [dynamic property f1] : String | L.cs:14:14:14:15 | access to local variable d1 : Object [dynamic property f1] : String | provenance | |
1167+
| L.cs:13:17:13:33 | call to method Source<String> : String | L.cs:13:9:13:10 | [post] access to local variable d1 : Object [dynamic property f1] : String | provenance | |
1168+
| L.cs:13:17:13:33 | call to method Source<String> : String | L.cs:13:9:13:10 | [post] access to local variable d1 : Object [dynamic property f1] : String | provenance | |
1169+
| L.cs:14:14:14:15 | access to local variable d1 : Object [dynamic property f1] : String | L.cs:14:14:14:18 | dynamic access to member f1 | provenance | |
1170+
| L.cs:14:14:14:15 | access to local variable d1 : Object [dynamic property f1] : String | L.cs:14:14:14:18 | dynamic access to member f1 | provenance | |
1171+
| L.cs:18:9:18:10 | [post] access to local variable d2 : Object [dynamic property f2] : String | L.cs:19:16:19:17 | (...) ... : L [dynamic property f2] : String | provenance | |
1172+
| L.cs:18:9:18:10 | [post] access to local variable d2 : Object [dynamic property f2] : String | L.cs:19:16:19:17 | (...) ... : L [dynamic property f2] : String | provenance | |
1173+
| L.cs:18:17:18:33 | call to method Source<String> : String | L.cs:18:9:18:10 | [post] access to local variable d2 : Object [dynamic property f2] : String | provenance | |
1174+
| L.cs:18:17:18:33 | call to method Source<String> : String | L.cs:18:9:18:10 | [post] access to local variable d2 : Object [dynamic property f2] : String | provenance | |
1175+
| L.cs:19:11:19:12 | access to local variable l2 : L [dynamic property f2] : String | L.cs:20:14:20:15 | access to local variable l2 : L [dynamic property f2] : String | provenance | |
1176+
| L.cs:19:11:19:12 | access to local variable l2 : L [dynamic property f2] : String | L.cs:20:14:20:15 | access to local variable l2 : L [dynamic property f2] : String | provenance | |
1177+
| L.cs:19:16:19:17 | (...) ... : L [dynamic property f2] : String | L.cs:19:11:19:12 | access to local variable l2 : L [dynamic property f2] : String | provenance | |
1178+
| L.cs:19:16:19:17 | (...) ... : L [dynamic property f2] : String | L.cs:19:11:19:12 | access to local variable l2 : L [dynamic property f2] : String | provenance | |
1179+
| L.cs:20:14:20:15 | access to local variable l2 : L [dynamic property f2] : String | L.cs:20:14:20:18 | access to property f2 | provenance | |
1180+
| L.cs:20:14:20:15 | access to local variable l2 : L [dynamic property f2] : String | L.cs:20:14:20:18 | access to property f2 | provenance | |
1181+
| L.cs:23:9:23:12 | [post] this access : L [property f3] : String | L.cs:24:17:24:18 | access to local variable d3 : L [property f3] : String | provenance | |
1182+
| L.cs:23:9:23:12 | [post] this access : L [property f3] : String | L.cs:24:17:24:18 | access to local variable d3 : L [property f3] : String | provenance | |
1183+
| L.cs:23:19:23:35 | call to method Source<String> : String | L.cs:23:9:23:12 | [post] this access : L [property f3] : String | provenance | |
1184+
| L.cs:23:19:23:35 | call to method Source<String> : String | L.cs:23:9:23:12 | [post] this access : L [property f3] : String | provenance | |
1185+
| L.cs:24:17:24:18 | access to local variable d3 : L [property f3] : String | L.cs:25:14:25:15 | access to local variable d3 : L [property f3] : String | provenance | |
1186+
| L.cs:24:17:24:18 | access to local variable d3 : L [property f3] : String | L.cs:25:14:25:15 | access to local variable d3 : L [property f3] : String | provenance | |
1187+
| L.cs:25:14:25:15 | access to local variable d3 : L [property f3] : String | L.cs:25:14:25:18 | dynamic access to member f3 | provenance | |
1188+
| L.cs:25:14:25:15 | access to local variable d3 : L [property f3] : String | L.cs:25:14:25:18 | dynamic access to member f3 | provenance | |
11651189
nodes
11661190
| A.cs:5:13:5:13 | access to local variable c : C | semmle.label | access to local variable c : C |
11671191
| A.cs:5:13:5:13 | access to local variable c : C | semmle.label | access to local variable c : C |
@@ -2415,6 +2439,36 @@ nodes
24152439
| K.cs:13:14:13:20 | access to field Strings : String[] [element] : String | semmle.label | access to field Strings : String[] [element] : String |
24162440
| K.cs:13:14:13:23 | access to array element | semmle.label | access to array element |
24172441
| K.cs:13:14:13:23 | access to array element | semmle.label | access to array element |
2442+
| L.cs:13:9:13:10 | [post] access to local variable d1 : Object [dynamic property f1] : String | semmle.label | [post] access to local variable d1 : Object [dynamic property f1] : String |
2443+
| L.cs:13:9:13:10 | [post] access to local variable d1 : Object [dynamic property f1] : String | semmle.label | [post] access to local variable d1 : Object [dynamic property f1] : String |
2444+
| L.cs:13:17:13:33 | call to method Source<String> : String | semmle.label | call to method Source<String> : String |
2445+
| L.cs:13:17:13:33 | call to method Source<String> : String | semmle.label | call to method Source<String> : String |
2446+
| L.cs:14:14:14:15 | access to local variable d1 : Object [dynamic property f1] : String | semmle.label | access to local variable d1 : Object [dynamic property f1] : String |
2447+
| L.cs:14:14:14:15 | access to local variable d1 : Object [dynamic property f1] : String | semmle.label | access to local variable d1 : Object [dynamic property f1] : String |
2448+
| L.cs:14:14:14:18 | dynamic access to member f1 | semmle.label | dynamic access to member f1 |
2449+
| L.cs:14:14:14:18 | dynamic access to member f1 | semmle.label | dynamic access to member f1 |
2450+
| L.cs:18:9:18:10 | [post] access to local variable d2 : Object [dynamic property f2] : String | semmle.label | [post] access to local variable d2 : Object [dynamic property f2] : String |
2451+
| L.cs:18:9:18:10 | [post] access to local variable d2 : Object [dynamic property f2] : String | semmle.label | [post] access to local variable d2 : Object [dynamic property f2] : String |
2452+
| L.cs:18:17:18:33 | call to method Source<String> : String | semmle.label | call to method Source<String> : String |
2453+
| L.cs:18:17:18:33 | call to method Source<String> : String | semmle.label | call to method Source<String> : String |
2454+
| L.cs:19:11:19:12 | access to local variable l2 : L [dynamic property f2] : String | semmle.label | access to local variable l2 : L [dynamic property f2] : String |
2455+
| L.cs:19:11:19:12 | access to local variable l2 : L [dynamic property f2] : String | semmle.label | access to local variable l2 : L [dynamic property f2] : String |
2456+
| L.cs:19:16:19:17 | (...) ... : L [dynamic property f2] : String | semmle.label | (...) ... : L [dynamic property f2] : String |
2457+
| L.cs:19:16:19:17 | (...) ... : L [dynamic property f2] : String | semmle.label | (...) ... : L [dynamic property f2] : String |
2458+
| L.cs:20:14:20:15 | access to local variable l2 : L [dynamic property f2] : String | semmle.label | access to local variable l2 : L [dynamic property f2] : String |
2459+
| L.cs:20:14:20:15 | access to local variable l2 : L [dynamic property f2] : String | semmle.label | access to local variable l2 : L [dynamic property f2] : String |
2460+
| L.cs:20:14:20:18 | access to property f2 | semmle.label | access to property f2 |
2461+
| L.cs:20:14:20:18 | access to property f2 | semmle.label | access to property f2 |
2462+
| L.cs:23:9:23:12 | [post] this access : L [property f3] : String | semmle.label | [post] this access : L [property f3] : String |
2463+
| L.cs:23:9:23:12 | [post] this access : L [property f3] : String | semmle.label | [post] this access : L [property f3] : String |
2464+
| L.cs:23:19:23:35 | call to method Source<String> : String | semmle.label | call to method Source<String> : String |
2465+
| L.cs:23:19:23:35 | call to method Source<String> : String | semmle.label | call to method Source<String> : String |
2466+
| L.cs:24:17:24:18 | access to local variable d3 : L [property f3] : String | semmle.label | access to local variable d3 : L [property f3] : String |
2467+
| L.cs:24:17:24:18 | access to local variable d3 : L [property f3] : String | semmle.label | access to local variable d3 : L [property f3] : String |
2468+
| L.cs:25:14:25:15 | access to local variable d3 : L [property f3] : String | semmle.label | access to local variable d3 : L [property f3] : String |
2469+
| L.cs:25:14:25:15 | access to local variable d3 : L [property f3] : String | semmle.label | access to local variable d3 : L [property f3] : String |
2470+
| L.cs:25:14:25:18 | dynamic access to member f3 | semmle.label | dynamic access to member f3 |
2471+
| L.cs:25:14:25:18 | dynamic access to member f3 | semmle.label | dynamic access to member f3 |
24182472
subpaths
24192473
| A.cs:6:24:6:24 | access to local variable c : C | A.cs:147:32:147:32 | c : C | A.cs:149:20:149:27 | object creation of type B : B [field c] : C | A.cs:6:17:6:25 | call to method Make : B [field c] : C |
24202474
| A.cs:6:24:6:24 | access to local variable c : C | A.cs:147:32:147:32 | c : C | A.cs:149:20:149:27 | object creation of type B : B [field c] : C | A.cs:6:17:6:25 | call to method Make : B [field c] : C |
@@ -2672,3 +2726,9 @@ testFailures
26722726
| J.cs:125:14:125:17 | (...) ... | J.cs:119:20:119:34 | call to method Source<Int32> : Int32 | J.cs:125:14:125:17 | (...) ... | $@ | J.cs:119:20:119:34 | call to method Source<Int32> : Int32 | call to method Source<Int32> : Int32 |
26732727
| K.cs:13:14:13:23 | access to array element | K.cs:7:17:7:33 | call to method Source<String> : String | K.cs:13:14:13:23 | access to array element | $@ | K.cs:7:17:7:33 | call to method Source<String> : String | call to method Source<String> : String |
26742728
| K.cs:13:14:13:23 | access to array element | K.cs:7:17:7:33 | call to method Source<String> : String | K.cs:13:14:13:23 | access to array element | $@ | K.cs:7:17:7:33 | call to method Source<String> : String | call to method Source<String> : String |
2729+
| L.cs:14:14:14:18 | dynamic access to member f1 | L.cs:13:17:13:33 | call to method Source<String> : String | L.cs:14:14:14:18 | dynamic access to member f1 | $@ | L.cs:13:17:13:33 | call to method Source<String> : String | call to method Source<String> : String |
2730+
| L.cs:14:14:14:18 | dynamic access to member f1 | L.cs:13:17:13:33 | call to method Source<String> : String | L.cs:14:14:14:18 | dynamic access to member f1 | $@ | L.cs:13:17:13:33 | call to method Source<String> : String | call to method Source<String> : String |
2731+
| L.cs:20:14:20:18 | access to property f2 | L.cs:18:17:18:33 | call to method Source<String> : String | L.cs:20:14:20:18 | access to property f2 | $@ | L.cs:18:17:18:33 | call to method Source<String> : String | call to method Source<String> : String |
2732+
| L.cs:20:14:20:18 | access to property f2 | L.cs:18:17:18:33 | call to method Source<String> : String | L.cs:20:14:20:18 | access to property f2 | $@ | L.cs:18:17:18:33 | call to method Source<String> : String | call to method Source<String> : String |
2733+
| L.cs:25:14:25:18 | dynamic access to member f3 | L.cs:23:19:23:35 | call to method Source<String> : String | L.cs:25:14:25:18 | dynamic access to member f3 | $@ | L.cs:23:19:23:35 | call to method Source<String> : String | call to method Source<String> : String |
2734+
| L.cs:25:14:25:18 | dynamic access to member f3 | L.cs:23:19:23:35 | call to method Source<String> : String | L.cs:25:14:25:18 | dynamic access to member f3 | $@ | L.cs:23:19:23:35 | call to method Source<String> : String | call to method Source<String> : String |

‎csharp/ql/test/library-tests/dataflow/fields/L.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,18 @@ private void M1()
1111
// dynamic write followed by dynamic read
1212
dynamic d1 = this;
1313
d1.f1 = Source<string>(1);
14-
Sink(d1.f1); // $ MISSING: hasValueFlow=1
14+
Sink(d1.f1); // $ hasValueFlow=1
1515

1616
// dynamic write followed by static read
1717
dynamic d2 = this;
1818
d2.f2 = Source<string>(2);
1919
L l2 = d2;
20-
Sink(l2.f2); // $ MISSING: hasValueFlow=2
20+
Sink(l2.f2); // $ hasValueFlow=2
2121

2222
// static write followed by dynamic read
2323
this.f3 = Source<string>(3);
2424
dynamic d3 = this;
25-
Sink(d3.f3); // $ MISSING: hasValueFlow=3
25+
Sink(d3.f3); // $ hasValueFlow=3
2626
}
2727

2828
public static void Sink(object o) { }

0 commit comments

Comments
 (0)