Tag 'linter-like' quality queries that don't use pointsto

Author: joefarebrother

python/ql/src/Imports/ImportandImportFrom.ql

@@ -2,7 +2,9 @@
  * @name Module is imported with 'import' and 'import from'
  * @description A module is imported with the "import" and "import from" statements
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  * @problem.severity recommendation
  * @sub-severity low
  * @precision very-high

python/ql/src/Imports/ModuleImportsItself.ql

@@ -2,7 +2,8 @@
  * @name Module imports itself
  * @description A module imports itself
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       useless-code
  * @problem.severity recommendation
  * @sub-severity high

python/ql/src/Imports/MultipleImports.ql

@@ -2,7 +2,8 @@
  * @name Module is imported more than once
  * @description Importing a module a second time has no effect and impairs readability
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       useless-code
  * @problem.severity recommendation
  * @sub-severity high

python/ql/src/Imports/UnintentionalImport.ql

@@ -3,8 +3,9 @@
  * @description Importing a module using 'import *' may unintentionally pollute the global
  *              namespace if the module does not define `__all__`
  * @kind problem
- * @tags maintainability
- *       modularity
+ * @tags quality
+ *       maintainability
+ *       readability
  * @problem.severity recommendation
  * @sub-severity high
  * @precision very-high

python/ql/src/Imports/UnusedImport.ql

@@ -2,7 +2,8 @@
  * @name Unused import
  * @description Import is not required as it is not used
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       useless-code
  * @problem.severity recommendation
  * @sub-severity high

python/ql/src/Statements/AssertOnTuple.ql

@@ -2,8 +2,9 @@
  * @name Asserting a tuple
  * @description Using an assert statement to test a tuple provides no validity checking.
  * @kind problem
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-670
  * @problem.severity error
  * @sub-severity low

python/ql/src/Statements/ConstantInConditional.ql

@@ -2,7 +2,8 @@
  * @name Constant in conditional expression or statement
  * @description The conditional is always true or always false
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       useless-code
  *       external/cwe/cwe-561
  *       external/cwe/cwe-570

python/ql/src/Statements/NestedLoopsSameVariable.ql

@@ -3,8 +3,9 @@
  * @description Nested loops in which the target variable is the same for each loop make
  *              the behavior of the loops difficult to understand.
  * @kind problem
- * @tags maintainability
- *       correctness
+ * @tags quality
+ *       maintainability
+ *       readability
  * @problem.severity recommendation
  * @sub-severity high
  * @precision very-high

python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql

@@ -3,7 +3,8 @@
  * @description Redefining a variable in an inner loop and then using
  *              the variable in an outer loop causes unexpected behavior.
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity error
  * @sub-severity low

python/ql/src/Statements/RedundantAssignment.ql

@@ -2,7 +2,8 @@
  * @name Redundant assignment
  * @description Assigning a variable to itself is useless and very likely indicates an error in the code.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       maintainability
  *       useless-code
  *       external/cwe/cwe-563
  * @problem.severity error