Skip to content

Commit 4e8a114

Browse files
committed
Python: Remove explicit jumpStep for default parameter values
tests added in github#5238 functionality added in github#6640
1 parent 70994b9 commit 4e8a114

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -576,9 +576,6 @@ predicate jumpStepSharedWithTypeTracker(Node nodeFrom, Node nodeTo) {
576576
r.getAttributeName(), nodeFrom) and
577577
nodeTo = r
578578
)
579-
or
580-
// Default value for parameter flows to that parameter
581-
defaultValueFlowStep(nodeFrom, nodeTo)
582579
}
583580

584581
/**
@@ -799,19 +796,6 @@ predicate attributeStoreStep(Node nodeFrom, AttributeContent c, PostUpdateNode n
799796
)
800797
}
801798

802-
predicate defaultValueFlowStep(CfgNode nodeFrom, CfgNode nodeTo) {
803-
exists(Function f, Parameter p, ParameterDefinition def |
804-
// `getArgByName` supports, unlike `getAnArg`, keyword-only parameters
805-
p = f.getArgByName(_) and
806-
nodeFrom.asExpr() = p.getDefault() and
807-
// The following expresses
808-
// nodeTo.(ParameterNode).getParameter() = p
809-
// without non-monotonic recursion
810-
def.getParameter() = p and
811-
nodeTo.getNode() = def.getDefiningNode()
812-
)
813-
}
814-
815799
/**
816800
* Holds if data can flow from `nodeFrom` to `nodeTo` via a read of content `c`.
817801
*/

0 commit comments

Comments
 (0)