Skip to content

Commit 4fa93a0

Browse files
committed
Address review comments
1 parent e7a3dc8 commit 4fa93a0

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1327,7 +1327,7 @@ module MakeImpl<InputSig Lang> {
13271327
)
13281328
or
13291329
// flow out of a callable
1330-
fwdFlowOut(node, state, cc, summaryCtx, argT, argAp, t, ap, apa)
1330+
fwdFlowOut(_, _, node, state, cc, summaryCtx, argT, argAp, t, ap, apa)
13311331
or
13321332
// flow through a callable
13331333
exists(
@@ -1633,14 +1633,6 @@ module MakeImpl<InputSig Lang> {
16331633
)
16341634
}
16351635

1636-
pragma[nomagic]
1637-
private predicate fwdFlowOut(
1638-
NodeEx out, FlowState state, CcNoCall outercc, ParamNodeOption summaryCtx, TypOption argT,
1639-
ApOption argAp, Typ t, Ap ap, ApApprox apa
1640-
) {
1641-
fwdFlowOut(_, _, out, state, outercc, summaryCtx, argT, argAp, t, ap, apa)
1642-
}
1643-
16441636
private module FwdTypeFlowInput implements TypeFlowInput {
16451637
predicate enableTypeFlow = Param::enableTypeFlow/0;
16461638

@@ -1654,7 +1646,7 @@ module MakeImpl<InputSig Lang> {
16541646

16551647
pragma[nomagic]
16561648
private predicate dataFlowTakenCallEdgeIn0(
1657-
DataFlowCall call, DataFlowCallable c, ParamNodeEx p, FlowState state, Cc innercc,
1649+
DataFlowCall call, DataFlowCallable c, ParamNodeEx p, FlowState state, CcCall innercc,
16581650
Typ t, Ap ap, boolean cc
16591651
) {
16601652
FwdFlowIn<FwdFlowInNoRestriction>::fwdFlowIn(call, c, p, state, _, innercc, _, _, _, t,

0 commit comments

Comments
 (0)