Skip to content

Commit 4ffe70d

Browse files
committed
C++: Respond to review comments.
1 parent 0b2b341 commit 4ffe70d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/SignAnalysisCommon.qll

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -516,12 +516,18 @@ module SignAnalysis<DeltaSig D> {
516516
*/
517517
private Sign guardedSsaSignOk(SemSsaVariable v, SsaReadPosition pos) {
518518
result = TPos() and
519+
// optimised version of
520+
// `forex(SemExpr bound | posBound(bound, v, pos) | posBoundOk(bound, v, pos))`
519521
posBoundGuardedSsaSignOk(v, pos)
520522
or
521523
result = TNeg() and
524+
// optimised version of
525+
// `forex(SemExpr bound | negBound(bound, v, pos) | negBoundOk(bound, v, pos))`
522526
negBoundGuardedSsaSignOk(v, pos)
523527
or
524528
result = TZero() and
529+
// optimised version of
530+
// `forex(SemExpr bound | zeroBound(bound, v, pos) | zeroBoundOk(bound, v, pos))`
525531
zeroBoundGuardedSsaSignOk(v, pos)
526532
}
527533

0 commit comments

Comments
 (0)