Ruby: fix a name clash for summaries called "delete"

asgerf · asgerf · commit 50a7b219284e · 2023-05-23T16:49:17.000+02:00
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/core/Array.qll b/ruby/ql/lib/codeql/ruby/frameworks/core/Array.qll
@@ -583,7 +583,8 @@ module Array {
 
   private class DeleteUnknownSummary extends DeleteSummary {
     DeleteUnknownSummary() {
-      this = "delete" and
+      // Note: take care to avoid a name clash with the "delete" summary from String.qll
+      this = "delete-unknown-key" and
       not exists(DataFlow::Content::getKnownElementIndex(mc.getArgument(0)))
     }
 

Original file line number	Diff line number	Diff line change
`@@ -583,7 +583,8 @@ module Array {`
`583`	`583`
`584`	`584`	`private class DeleteUnknownSummary extends DeleteSummary {`
`585`	`585`	`DeleteUnknownSummary() {`
`586`		`- this = "delete" and`
	`586`	`+ // Note: take care to avoid a name clash with the "delete" summary from String.qll`
	`587`	`+ this = "delete-unknown-key" and`
`587`	`588`	`not exists(DataFlow::Content::getKnownElementIndex(mc.getArgument(0)))`
`588`	`589`	`}`
`589`	`590`