Skip to content

Commit 51321a2

Browse files
committed
Swift: Correct models in Data.qll.
1 parent 5dfb07c commit 51321a2

File tree

2 files changed

+5
-5
lines changed
  • swift/ql
    • lib/codeql/swift/frameworks/StandardLibrary
    • test/library-tests/dataflow/taint/libraries

2 files changed

+5
-5
lines changed

swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Data.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ private class DataSummaries extends SummaryModelCsv {
2626
";Data;true;base64EncodedData(options:);;;Argument[-1];ReturnValue;taint",
2727
";Data;true;base64EncodedString(options:);;;Argument[-1];ReturnValue;taint",
2828
";Data;true;compactMap(_:);;;Argument[-1];ReturnValue;taint",
29-
";Data;true;copyBytes(to:);;;Argument[-1];Argument[0];taint",
30-
";Data;true;copyBytes(to:count:);;;Argument[-1];Argument[0];taint",
31-
";Data;true;copyBytes(to:from:);;;Argument[-1];Argument[0];taint",
29+
";DataProtocol;true;copyBytes(to:);;;Argument[-1];Argument[0];taint",
30+
";DataProtocol;true;copyBytes(to:count:);;;Argument[-1];Argument[0];taint",
31+
";DataProtocol;true;copyBytes(to:from:);;;Argument[-1];Argument[0];taint",
3232
";Data;true;flatMap(_:);;;Argument[-1];ReturnValue;taint",
3333
";Data;true;insert(contentsOf:at:);;;Argument[0];Argument[-1];taint",
3434
";Data;true;map(_:);;;Argument[-1];ReturnValue;taint",

swift/ql/test/library-tests/dataflow/taint/libraries/data.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,10 +277,10 @@ func taintThroughData() {
277277
let dataTainted43 = source() as! UnsafeRawBufferPointer
278278
let pointerTainted43 = UnsafeMutableRawBufferPointer.allocate(byteCount: 0, alignment: 0)
279279
dataTainted43.copyBytes(to: pointerTainted43)
280-
sink(arg: pointerTainted43) // $ MISSING: tainted=277
280+
sink(arg: pointerTainted43) // $ tainted=277
281281

282282
let dataTainted44 = source() as! Array<UInt8>
283283
let pointerTainted44 = UnsafeMutableRawBufferPointer.allocate(byteCount: 0, alignment: 0)
284284
dataTainted44.copyBytes(to: pointerTainted44)
285-
sink(arg: pointerTainted44) // $ MISSING: tainted=282
285+
sink(arg: pointerTainted44) // $ tainted=282
286286
}

0 commit comments

Comments
 (0)