Skip to content

Commit 586c880

Browse files
committed
Move the sources back the .ql files
Otherwise they would both apply at the same time, making both versions of the query identical.
1 parent e9bad32 commit 586c880

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

java/ql/src/experimental/Security/CWE/CWE-078/CommandInjectionRuntimeExec.ql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
import CommandInjectionRuntimeExec
1515
import ExecUserFlow::PathGraph
1616

17+
class RemoteSource extends Source instanceof RemoteFlowSource { }
18+
1719
from
1820
ExecUserFlow::PathNode source, ExecUserFlow::PathNode sink, DataFlow::Node sourceCmd,
1921
DataFlow::Node sinkCmd

java/ql/src/experimental/Security/CWE/CWE-078/CommandInjectionRuntimeExec.qll

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ module ExecCmdFlow = TaintTracking::Global<ExecCmdFlowConfig>;
3030

3131
abstract class Source extends DataFlow::Node { }
3232

33-
class RemoteSource extends Source instanceof RemoteFlowSource { }
34-
35-
class LocalSource extends Source instanceof LocalUserInput { }
36-
3733
module ExecUserFlowConfig implements DataFlow::ConfigSig {
3834
predicate isSource(DataFlow::Node source) { source instanceof Source }
3935

java/ql/src/experimental/Security/CWE/CWE-078/CommandInjectionRuntimeExecLocal.ql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import CommandInjectionRuntimeExec
1616
import ExecUserFlow::PathGraph
1717

18+
class LocalSource extends Source instanceof LocalUserInput { }
19+
1820
from
1921
ExecUserFlow::PathNode source, ExecUserFlow::PathNode sink, DataFlow::Node sourceCmd,
2022
DataFlow::Node sinkCmd

0 commit comments

Comments
 (0)