JS: Update InsecureRandomness

asgerf · asgerf · commit 58a557b18e87 · 2023-07-11T14:56:43.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/InsecureRandomnessQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/InsecureRandomnessQuery.qll
@@ -27,11 +27,9 @@ class Configuration extends TaintTracking::Configuration {
     node instanceof Sanitizer
   }
 
-  override predicate isSanitizerEdge(DataFlow::Node pred, DataFlow::Node succ) {
+  override predicate isSanitizerOut(DataFlow::Node node) {
     // stop propagation at the sinks to avoid double reporting
-    pred instanceof Sink and
-    // constrain succ
-    pred = succ.getAPredecessor()
+    this.isSink(node)
   }
 
   override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,9 @@ class Configuration extends TaintTracking::Configuration {`
`27`	`27`	`node instanceof Sanitizer`
`28`	`28`	`}`
`29`	`29`
`30`		`- override predicate isSanitizerEdge(DataFlow::Node pred, DataFlow::Node succ) {`
	`30`	`+ override predicate isSanitizerOut(DataFlow::Node node) {`
`31`	`31`	`// stop propagation at the sinks to avoid double reporting`
`32`		`- pred instanceof Sink and`
`33`		`- // constrain succ`
`34`		`- pred = succ.getAPredecessor()`
	`32`	`+ this.isSink(node)`
`35`	`33`	`}`
`36`	`34`
`37`	`35`	`override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {`