Skip to content

Commit 58bd2f7

Browse files
committed
Address code review comments
1 parent e7f6d53 commit 58bd2f7

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ deprecated class IntentRedirectionConfiguration extends TaintTracking::Configura
2828
}
2929
}
3030

31-
private module IntentRedirectionConfig implements DataFlow::ConfigSig {
31+
/** A taint tracking configuration for tainted Intents being used to start Android components. */
32+
module IntentRedirectionConfig implements DataFlow::ConfigSig {
3233
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
3334

3435
predicate isSink(DataFlow::Node sink) { sink instanceof IntentRedirectionSink }
@@ -40,7 +41,7 @@ private module IntentRedirectionConfig implements DataFlow::ConfigSig {
4041
}
4142
}
4243

43-
/** A taint tracking configuration for tainted Intents being used to start Android components. */
44+
/** Tracks the flow of tainted Intents being used to start Android components. */
4445
module IntentRedirectionFlow = TaintTracking::Make<IntentRedirectionConfig>;
4546

4647
/**

java/ql/lib/semmle/code/java/security/UnsafeAndroidAccessQuery.qll

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,18 @@ deprecated class FetchUntrustedResourceConfiguration extends TaintTracking::Conf
2323
}
2424
}
2525

26-
private module FetchUntrustedResourceConfig implements DataFlow::ConfigSig {
26+
/**
27+
* A taint configuration tracking flow from untrusted inputs to a resource fetching call.
28+
*/
29+
module FetchUntrustedResourceConfig implements DataFlow::ConfigSig {
2730
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
2831

2932
predicate isSink(DataFlow::Node sink) { sink instanceof UrlResourceSink }
3033

3134
predicate isBarrier(DataFlow::Node sanitizer) { sanitizer instanceof RequestForgerySanitizer }
3235
}
3336

37+
/**
38+
* Detects taint flow from untrusted inputs to a resource fetching call.
39+
*/
3440
module FetchUntrustedResourceFlow = TaintTracking::Make<FetchUntrustedResourceConfig>;

0 commit comments

Comments
 (0)