Skip to content

Commit 5959a73

Browse files
committed
Only recommend GCM, and tighten wording
1 parent 5351f5b commit 5959a73

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

java/ql/lib/semmle/code/java/security/Encryption.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,11 +219,11 @@ predicate insecureAlgorithm(string name, string reason) {
219219
or
220220
name = "ECB" and
221221
reason =
222-
"Encryption mode ECB, as in AES/ECB/NoPadding for example, is vulnerable to replay and other attacks. Consider using a different encryption mode, like CBC or GCM, instead."
222+
"ECB mode, as in AES/ECB/NoPadding for example, is vulnerable to replay and other attacks. Consider using GCM instead."
223223
or
224224
name = "AES/CBC/PKCS[57]Padding" and
225225
reason =
226-
"CBC mode of operation with PKCS#5 or PKCS#7 padding is vulnerable to padding oracle attacks. Consider using GCM encryption mode instead."
226+
"CBC mode with PKCS#5 or PKCS#7 padding is vulnerable to padding oracle attacks. Consider using GCM instead."
227227
}
228228

229229
/**

0 commit comments

Comments
 (0)