Skip to content

Commit 5acfc52

Browse files
committed
Add dependent stub classes for the test case
1 parent 1e4addb commit 5acfc52

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
| InsecureJavaMail.java:33:28:33:73 | getInstance(...) | Java mailing has insecure SSL configuration |
2-
| InsecureJavaMail.java:41:3:41:29 | setSSLOnConnect(...) | Java mailing has insecure SSL configuration |
1+
| InsecureJavaMail.java:32:27:32:72 | getInstance(...) | Java mailing has insecure SSL configuration |
2+
| InsecureJavaMail.java:40:3:40:29 | setSSLOnConnect(...) | Java mailing has insecure SSL configuration |

java/ql/test/experimental/query-tests/security/CWE-297/InsecureJavaMail.java

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,27 @@
99

1010
import org.apache.commons.mail.DefaultAuthenticator;
1111
import org.apache.commons.mail.Email;
12-
import org.apache.commons.mail.EmailException;
1312
import org.apache.commons.mail.SimpleEmail;
1413

1514
import java.util.Properties;
1615

1716
class InsecureJavaMail {
1817
public void testJavaMail() {
19-
final Properties properties = new Properties();
20-
properties.put("mail.transport.protocol", "protocol");
21-
properties.put("mail.smtp.host", "hostname");
22-
properties.put("mail.smtp.socketFactory.class", "classname");
18+
final Properties properties = new Properties();
19+
properties.put("mail.transport.protocol", "protocol");
20+
properties.put("mail.smtp.host", "hostname");
21+
properties.put("mail.smtp.socketFactory.class", "classname");
2322

24-
final javax.mail.Authenticator authenticator = new javax.mail.Authenticator() {
25-
protected PasswordAuthentication getPasswordAuthentication() {
26-
return new PasswordAuthentication("username", "password");
27-
}
28-
};
29-
if (null != authenticator) {
30-
properties.put("mail.smtp.auth", "true");
31-
// properties.put("mail.smtp.ssl.checkserveridentity", "true");
23+
final javax.mail.Authenticator authenticator = new javax.mail.Authenticator() {
24+
protected PasswordAuthentication getPasswordAuthentication() {
25+
return new PasswordAuthentication("username", "password");
3226
}
33-
final Session session = Session.getInstance(properties, authenticator);
27+
};
28+
if (null != authenticator) {
29+
properties.put("mail.smtp.auth", "true");
30+
// properties.put("mail.smtp.ssl.checkserveridentity", "true");
31+
}
32+
final Session session = Session.getInstance(properties, authenticator);
3433
}
3534

3635
public void testSimpleMail() {

0 commit comments

Comments
 (0)