Skip to content

Commit 5bd0442

Browse files
jorgectfasgerf
andauthored
Apply suggestions from code review
Co-authored-by: Asger F <[email protected]>
1 parent 08b9a5e commit 5bd0442

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ module CodeInjection {
316316
* A value interpreted as code by the `webix` library.
317317
*/
318318
class WebixExec extends Sink {
319-
WebixExec() { this = DataFlow::moduleImport("webix").getAMemberCall("exec").getArgument(0) }
319+
WebixExec() { this = API::moduleImport("webix").getMember("exec").getParameter(0).asSink() }
320320
}
321321

322322
/** A sink for code injection via template injection. */
@@ -431,15 +431,15 @@ module CodeInjection {
431431
*/
432432
class WebixTemplateSink extends TemplateSink {
433433
WebixTemplateSink() {
434-
this = DataFlow::moduleImport("webix").getAMemberCall("ui").getOptionArgument(0, "template")
434+
this = API::moduleImport("webix").getMember("ui").getParameter(0).getMember("template").asSink()
435435
or
436436
this.asExpr() =
437-
DataFlow::moduleImport("webix")
438-
.getAMemberCall("ui")
439-
.getOptionArgument(0, "template")
440-
.asExpr()
441-
.(Function)
442-
.getAReturnedExpr()
437+
API::moduleImport("webix")
438+
.getMember("ui")
439+
.getParameter(0)
440+
.getMember("template")
441+
.getReturn()
442+
.asSink()
443443
}
444444
}
445445

0 commit comments

Comments
 (0)