Skip to content

Commit 637baab

Browse files
committed
JS: Clarify why there are no SSA definitions
1 parent 2fb1084 commit 637baab

File tree

1 file changed

+8
-2
lines changed
  • javascript/ql/lib/semmle/javascript/dataflow/internal/sharedlib

1 file changed

+8
-2
lines changed

javascript/ql/lib/semmle/javascript/dataflow/internal/sharedlib/Ssa.qll

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,17 @@ module SsaDataflowInput implements DataFlowIntegrationInputSig {
6060
predicate hasCfgNode(js::BasicBlock bb, int i) { this = bb.getNode(i) }
6161
}
6262

63-
predicate ssaDefAssigns(WriteDefinition def, Expr value) { none() } // Not handled here
63+
predicate ssaDefAssigns(WriteDefinition def, Expr value) {
64+
// This library only handles use-use flow after a post-update, there are no definitions, only uses.
65+
none()
66+
}
6467

6568
class Parameter = js::Parameter;
6669

67-
predicate ssaDefInitializesParam(WriteDefinition def, Parameter p) { none() } // Not handled here
70+
predicate ssaDefInitializesParam(WriteDefinition def, Parameter p) {
71+
// This library only handles use-use flow after a post-update, there are no definitions, only uses.
72+
none()
73+
}
6874

6975
cached
7076
Expr getARead(Definition def) {

0 commit comments

Comments
 (0)