Skip to content

Commit 65f4ef7

Browse files
committed
C++: accept false positive tests after merge
The IR false positives are due to the same path length limit as the AST false positives on the same line.
1 parent a7efa0d commit 65f4ef7

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

cpp/ql/test/library-tests/dataflow/fields/complex.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ void bar(Outer &b)
4848
// in _some_ access path somewhere in the search. That makes the library conclude
4949
// that there could be flow to `b.inner.f.a_` even when the flow was actually to
5050
// `b.inner.f.b_`.
51-
sink(b.inner.f.a()); // $ast=62:19 $f+:ast=63:19 $ast=64:19 $f+:ast=65:19 $ir=62:19 $ir=64:19
52-
sink(b.inner.f.b()); // $f+:ast=62:19 $ast=63:19 $f+:ast=64:19 $ast=65:19 $ir=63:19 $ir=65:19
51+
sink(b.inner.f.a()); // $ast=62:19 $f+:ast=63:19 $ast=64:19 $f+:ast=65:19 $ir=62:19 $f+:ir=63:19 $ir=64:19 $f+:ir=65:19
52+
sink(b.inner.f.b()); // $f+:ast=62:19 $ast=63:19 $f+:ast=64:19 $ast=65:19 $f+:ir=62:19 $ir=63:19 $f+:ir=64:19 $ir=65:19
5353
}
5454

5555
void foo()
Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +0,0 @@
1-
| complex.cpp:51:18:51:18 | call to a | Unexpected result: ir=63:19 |
2-
| complex.cpp:51:18:51:18 | call to a | Unexpected result: ir=65:19 |
3-
| complex.cpp:52:18:52:18 | call to b | Unexpected result: ir=62:19 |
4-
| complex.cpp:52:18:52:18 | call to b | Unexpected result: ir=64:19 |

0 commit comments

Comments
 (0)