C#: Address review comments.

michaelnebel · michaelnebel · commit 684c80c31a1f · 2024-12-10T13:13:11.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
@@ -606,7 +606,12 @@ private bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount,
                     {
                         if (chain is null || cert is null)
                         {
-                            logger.LogWarning("Certificate validation trivially failed due to missing chain or certificate.");
+                            var msg = cert is null && chain is null
+                                ? "certificate and chain"
+                                : chain is null
+                                    ? "chain"
+                                    : "certificate";
+                            logger.LogWarning($"Dependabot proxy certificate validation failed due to missing {msg}");
                             return false;
                         }
                         chain.ChainPolicy.TrustMode = X509ChainTrustMode.CustomRootTrust;

Original file line number	Diff line number	Diff line change
`@@ -606,7 +606,12 @@ private bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount,`
`606`	`606`	`{`
`607`	`607`	`if (chain is null \|\| cert is null)`
`608`	`608`	`{`
`609`		`- logger.LogWarning("Certificate validation trivially failed due to missing chain or certificate.");`
	`609`	`+ var msg = cert is null && chain is null`
	`610`	`+ ? "certificate and chain"`
	`611`	`+ : chain is null`
	`612`	`+ ? "chain"`
	`613`	`+ : "certificate";`
	`614`	`+ logger.LogWarning($"Dependabot proxy certificate validation failed due to missing {msg}");`
`610`	`615`	`return false;`
`611`	`616`	`}`
`612`	`617`	`chain.ChainPolicy.TrustMode = X509ChainTrustMode.CustomRootTrust;`