Skip to content

Commit 6a84e6c

Browse files
committed
Add the merged PathGraph to all copies of the InlineFlowTest library
1 parent d82c3ce commit 6a84e6c

File tree

4 files changed

+34
-5
lines changed

4 files changed

+34
-5
lines changed

csharp/ql/test/TestUtilities/InlineFlowTest.qll

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
* import csharp
77
* import TestUtilities.InlineFlowTest
88
* import DefaultFlowTest
9-
* import ValueFlow::PathGraph
9+
* import PathGraph
1010
*
11-
* from ValueFlow::PathNode source, ValueFlow::PathNode sink
12-
* where ValueFlow::flowPath(source, sink)
11+
* from PathNode source, PathNode sink
12+
* where flowPath(source, sink)
1313
* select sink, source, sink, "$@", source, source.toString()
1414
*
1515
* ```
@@ -101,6 +101,12 @@ module FlowTest<DataFlow::ConfigSig ValueFlowConfig, DataFlow::ConfigSig TaintFl
101101
}
102102

103103
import MakeTest<InlineTest>
104+
import DataFlow::MergePathGraph<ValueFlow::PathNode, TaintFlow::PathNode, ValueFlow::PathGraph, TaintFlow::PathGraph>
105+
106+
predicate flowPath(PathNode source, PathNode sink) {
107+
ValueFlow::flowPath(source.asPathNode1(), sink.asPathNode1()) or
108+
TaintFlow::flowPath(source.asPathNode2(), sink.asPathNode2())
109+
}
104110
}
105111

106112
module DefaultFlowTest = FlowTest<DefaultFlowConfig, DefaultFlowConfig>;

go/ql/test/TestUtilities/InlineFlowTest.qll

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@
66
* import go
77
* import TestUtilities.InlineFlowTest
88
* import DefaultFlowTest
9+
* import PathGraph
10+
*
11+
* from PathNode source, PathNode sink
12+
* where flowPath(source, sink)
13+
* select sink, source, sink, "$@", source, source.toString()
914
* ```
1015
*
1116
* To declare expectations, you can use the $hasTaintFlow or $hasValueFlow comments within the test source files.
@@ -88,6 +93,12 @@ module FlowTest<DataFlow::ConfigSig ValueFlowConfig, DataFlow::ConfigSig TaintFl
8893
}
8994

9095
import MakeTest<InlineTest>
96+
import DataFlow::MergePathGraph<ValueFlow::PathNode, TaintFlow::PathNode, ValueFlow::PathGraph, TaintFlow::PathGraph>
97+
98+
predicate flowPath(PathNode source, PathNode sink) {
99+
ValueFlow::flowPath(source.asPathNode1(), sink.asPathNode1()) or
100+
TaintFlow::flowPath(source.asPathNode2(), sink.asPathNode2())
101+
}
91102
}
92103

93104
module DefaultFlowTest = FlowTest<DefaultFlowConfig, DefaultFlowConfig>;

java/ql/test/TestUtilities/InlineFlowTest.qll

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
* import java
77
* import TestUtilities.InlineFlowTest
88
* import DefaultFlowTest
9+
* import PathGraph
10+
*
11+
* from PathNode source, PathNode sink
12+
* where flowPath(source, sink)
13+
* select sink, source, sink, "$@", source, source.toString()
14+
915
* ```
1016
*
1117
* To declare expectations, you can use the $hasTaintFlow or $hasValueFlow comments within the test source files.
@@ -95,6 +101,12 @@ module FlowTest<DataFlow::ConfigSig ValueFlowConfig, DataFlow::ConfigSig TaintFl
95101
}
96102

97103
import MakeTest<InlineTest>
104+
import DataFlow::MergePathGraph<ValueFlow::PathNode, TaintFlow::PathNode, ValueFlow::PathGraph, TaintFlow::PathGraph>
105+
106+
predicate flowPath(PathNode source, PathNode sink) {
107+
ValueFlow::flowPath(source.asPathNode1(), sink.asPathNode1()) or
108+
TaintFlow::flowPath(source.asPathNode2(), sink.asPathNode2())
109+
}
98110
}
99111

100112
module DefaultFlowTest = FlowTest<DefaultFlowConfig, DefaultFlowConfig>;

ruby/ql/test/TestUtilities/InlineFlowTest.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
* import DefaultFlowTest
88
* import PathGraph
99
*
10-
* from ValueFlow::PathNode source, ValueFlow::PathNode sink
11-
* where ValueFlow::flowPath(source, sink)
10+
* from PathNode source, PathNode sink
11+
* where flowPath(source, sink)
1212
* select sink, source, sink, "$@", source, source.toString()
1313
* ```
1414
*

0 commit comments

Comments
 (0)