Skip to content

Commit 722b7bb

Browse files
geoffw0mchammer01
andauthored
Apply suggestions from code review
Co-authored-by: mc <[email protected]>
1 parent edd1f25 commit 722b7bb

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

rust/ql/src/queries/security/CWE-328/WeakSensitiveDataHashing.qhelp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<overview>
66
<p>
77
A broken or weak cryptographic hash function can leave data
8-
vulnerable, and should not be used in security related code.
8+
vulnerable, and should not be used in security-related code.
99
</p>
1010

1111
<p>
@@ -24,7 +24,7 @@
2424
</li>
2525
<li>
2626
<b>Brute force</b>. For passwords and other data with limited
27-
input space, if you know a hash value <code>h(x)</code>
27+
input space, if you know a hash value <code>h(x)</code>,
2828
you should not be able to find the input <code>x</code> even using
2929
a brute force attack (without significant computational effort).
3030
</li>
@@ -37,7 +37,8 @@
3737
<p>
3838
All of MD5, SHA-1, SHA-2 and SHA-3 are weak against offline brute forcing, so
3939
they are not suitable for hashing passwords. This includes SHA-224, SHA-256,
40-
SHA-384 and SHA-512, which are in the SHA-2 family.
40+
41+
SHA-384, and SHA-512, which are in the SHA-2 family.
4142
</p>
4243

4344
<p>
@@ -94,7 +95,8 @@
9495
and
9596
<a href="https://cheatsheetseries.owasp.org/cheatsheets/Transport_Layer_Security_Cheat_Sheet.html">
9697
Transport Layer Security Cheat Sheet
97-
</a>
98+
99+
</a>.
98100
</li>
99101
<li>
100102
GitHub:
@@ -104,13 +106,13 @@
104106
and
105107
<a href="https://github.com/RustCrypto/password-hashes?tab=readme-ov-file#rustcrypto-password-hashes">
106108
RustCrypto: Password Hashes
107-
</a>
109+
</a>.
108110
</li>
109111
<li>
110112
The RustCrypto Book:
111113
<a href="https://rustcrypto.org/key-derivation/hashing-password.html">
112114
Password Hashing
113-
</a>
115+
</a>.
114116
</li>
115117
</references>
116118

0 commit comments

Comments
 (0)