JS: Add: Test cases use of returnless function in findLast and findLastIndex

Napalys · Napalys · commit 7250099f6c20 · 2024-11-15T14:42:11.000+01:00
diff --git a/javascript/ql/test/query-tests/Statements/UseOfReturnlessFunction/tst.js b/javascript/ql/test/query-tests/Statements/UseOfReturnlessFunction/tst.js
@@ -107,3 +107,13 @@ class Bar extends Foo {
 		console.log(super()); // OK.
 	}
 }
+
+() => {
+	let equals = (x, y) => { return x === y; };
+
+	var foo = [1,2,3].findLastIndex(n => { equals(n, 3); }) // NOT OK -- Currently not flagged, but should be.
+	console.log(foo);
+
+	var foo = [1,2,3].findLast(n => { equals(n, 3); }) // NOT OK -- Currently not flagged, but should be.
+	console.log(foo);
+}

Original file line number	Diff line number	Diff line change
`@@ -107,3 +107,13 @@ class Bar extends Foo {`
`107`	`107`	`console.log(super()); // OK.`
`108`	`108`	`}`
`109`	`109`	`}`
	`110`	`+`
	`111`	`+() => {`
	`112`	`+ let equals = (x, y) => { return x === y; };`
	`113`	`+`
	`114`	`+ var foo = [1,2,3].findLastIndex(n => { equals(n, 3); }) // NOT OK -- Currently not flagged, but should be.`
	`115`	`+ console.log(foo);`
	`116`	`+`
	`117`	`+ var foo = [1,2,3].findLast(n => { equals(n, 3); }) // NOT OK -- Currently not flagged, but should be.`
	`118`	`+ console.log(foo);`
	`119`	`+}`