Skip to content

Commit 7336dd1

Browse files
authored
Merge pull request github#16482 from grakshith/rakshith/tune-java-crypto
Java: Add RSA/ECB/OEAP ciphers to the list of secure algorithms
2 parents 7ecf1f9 + 798a736 commit 7336dd1

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

java/ql/lib/semmle/code/java/security/BrokenCryptoAlgorithmQuery.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ private class ShortStringLiteral extends StringLiteral {
1515
class BrokenAlgoLiteral extends ShortStringLiteral {
1616
BrokenAlgoLiteral() {
1717
this.getValue().regexpMatch(getInsecureAlgorithmRegex()) and
18+
// Exclude RSA/ECB/.* ciphers.
19+
not this.getValue().regexpMatch("RSA/ECB.*") and
1820
// Exclude German and French sentences.
1921
not this.getValue().regexpMatch(".*\\p{IsLowercase} des \\p{IsLetter}.*")
2022
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: majorAnalysis
3+
---
4+
* The query `java/weak-cryptographic-algorithm` no longer alerts about `RSA/ECB` algorithm strings.

0 commit comments

Comments
 (0)