Java: Refactor most of the logic out of the model editor query files

Author: koesie10

java/ql/src/utils/modeleditor/ApplicationModeEndpoints.ql

@@ -8,12 +8,9 @@
  */
 
 private import java
+private import ApplicationModeEndpointsQuery
 private import ModelEditor
 
-class ExternalEndpoint extends Endpoint {
-  ExternalEndpoint() { not this.fromSource() }
-}
-
 private Call aUsage(ExternalEndpoint endpoint) {
   result.getCallee().getSourceDeclaration() = endpoint
 }

java/ql/src/utils/modeleditor/ApplicationModeEndpointsQuery.qll

@@ -0,0 +1,9 @@
+private import java
+private import ModelEditor
+
+/**
+ * A class of effectively public callables in library code.
+ */
+class ExternalEndpoint extends Endpoint {
+  ExternalEndpoint() { not this.fromSource() }
+}

java/ql/src/utils/modeleditor/FrameworkModeEndpoints.ql

@@ -8,11 +8,9 @@
  */
 
 private import java
-private import semmle.code.java.dataflow.internal.ModelExclusions
+private import FrameworkModeEndpointsQuery
 private import ModelEditor
 
-class PublicEndpointFromSource extends Endpoint, ModelApi { }
-
 from PublicEndpointFromSource endpoint, string apiName, boolean supported, string type
 where
   apiName = endpoint.getApiName() and

java/ql/src/utils/modeleditor/FrameworkModeEndpointsQuery.qll

@@ -0,0 +1,8 @@
+private import java
+private import semmle.code.java.dataflow.internal.ModelExclusions
+private import ModelEditor
+
+/**
+ * A class of effectively public callables from source code.
+ */
+class PublicEndpointFromSource extends Endpoint, ModelApi { }