Added more heuristic ignorable functions.

bdrodes · bdrodes · commit 7604938960c0 · 2026-01-29T12:10:32.000-05:00
diff --git a/cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql b/cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql
@@ -67,6 +67,11 @@ class IgnorableFunction extends Function {
     this.getName().toLowerCase().matches("%persian%")
     or
     this.getFile().getBaseName().toLowerCase().matches("%persian%")
+    or
+    // misc. from string/char converters heuristic
+    this.getName()
+        .toLowerCase()
+        .matches(["%char%to%", "%string%to%", "%from%char%", "%from%string%"])
   }
 }
 
@@ -730,5 +735,6 @@ where
       dayOrMonthValSrc.asExpr().getValue().toInt() <= 27
     )
   )
+// TODO: all days to sink are safe?
 select sink, src, sink,
   "Year field has been modified, but no appropriate check for LeapYear was found."

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,11 @@ class IgnorableFunction extends Function {`
`67`	`67`	`this.getName().toLowerCase().matches("%persian%")`
`68`	`68`	`or`
`69`	`69`	`this.getFile().getBaseName().toLowerCase().matches("%persian%")`
	`70`	`+ or`
	`71`	`+ // misc. from string/char converters heuristic`
	`72`	`+ this.getName()`
	`73`	`+ .toLowerCase()`
	`74`	`+ .matches(["%char%to%", "%string%to%", "%from%char%", "%from%string%"])`
`70`	`75`	`}`
`71`	`76`	`}`
`72`	`77`
`@@ -730,5 +735,6 @@ where`
`730`	`735`	`dayOrMonthValSrc.asExpr().getValue().toInt() <= 27`
`731`	`736`	`)`
`732`	`737`	`)`
	`738`	`+// TODO: all days to sink are safe?`
`733`	`739`	`select sink, src, sink,`
`734`	`740`	`"Year field has been modified, but no appropriate check for LeapYear was found."`