Skip to content

Commit 77b88af

Browse files
committed
Removing commented out code and altering comments to explain why the code was removed.
1 parent cc953c8 commit 77b88af

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

cpp/ql/lib/semmle/code/cpp/security/BufferAccess.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,7 @@ class StrncpyBA extends BufferAccess {
129129
result = this.(FunctionCall).getArgument(0) and
130130
bufferDesc = "destination buffer" and
131131
accessType = 2
132-
// Ignore this case as reading past the source null terminator is not the behavior of strncpy
133-
// or
134-
// result = this.(FunctionCall).getArgument(1) and
135-
// bufferDesc = "source buffer" and
136-
// accessType = 2
132+
// NOTE, ignoring getting the source buffer (arg 1) since reading past the the source null terminator is not the behavior of strncpy
137133
}
138134

139135
override Expr getSizeExpr() { result = this.(FunctionCall).getArgument(2) }

0 commit comments

Comments
 (0)