Skip to content

Commit 77f3a70

Browse files
committed
Ruby: renames for rb/xpath-injection
1 parent 42cd586 commit 77f3a70

File tree

2 files changed

+19
-14
lines changed

2 files changed

+19
-14
lines changed

ruby/ql/lib/codeql/ruby/security/XpathInjectionQuery.qll

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,23 @@ private import codeql.ruby.DataFlow
1010
private import codeql.ruby.TaintTracking
1111
import XpathInjectionCustomizations::XpathInjection
1212

13-
/** Provides a taint-tracking configuration for detecting "Xpath Injection" vulnerabilities. */
14-
module XpathInjection {
15-
/**
16-
* A taint-tracking configuration for detecting "Xpath Injection" vulnerabilities.
17-
*/
18-
private module Config implements DataFlow::ConfigSig {
19-
predicate isSource(DataFlow::Node source) { source instanceof Source }
13+
/**
14+
* Provides a taint-tracking configuration for detecting "Xpath Injection" vulnerabilities.
15+
* DEPRECATED: Use `XpathInjectionFlow`
16+
*/
17+
deprecated module XpathInjection {
18+
import TaintTracking::Global<XpathInjectionConfig>
19+
}
2020

21-
predicate isSink(DataFlow::Node sink) { sink instanceof Sink }
21+
private module XpathInjectionConfig implements DataFlow::ConfigSig {
22+
predicate isSource(DataFlow::Node source) { source instanceof Source }
2223

23-
predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
24-
}
24+
predicate isSink(DataFlow::Node sink) { sink instanceof Sink }
2525

26-
import TaintTracking::Global<Config>
26+
predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
2727
}
28+
29+
/**
30+
* Taint-tracking for detecting "Xpath Injection" vulnerabilities.
31+
*/
32+
module XpathInjectionFlow = TaintTracking::Global<XpathInjectionConfig>;

ruby/ql/src/experimental/xpath-injection/XpathInjection.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313

1414
import codeql.ruby.DataFlow
1515
import codeql.ruby.security.XpathInjectionQuery
16-
import XpathInjection::PathGraph
16+
import XpathInjectionFlow::PathGraph
1717

18-
from XpathInjection::PathNode source, XpathInjection::PathNode sink
19-
where XpathInjection::flowPath(source, sink)
18+
from XpathInjectionFlow::PathNode source, XpathInjectionFlow::PathNode sink
19+
where XpathInjectionFlow::flowPath(source, sink)
2020
select sink.getNode(), source, sink, "XPath expression depends on a $@.", source.getNode(),
2121
"user-provided value"

0 commit comments

Comments
 (0)