Skip to content

Commit 79fb6a6

Browse files
MathiasVPMathiasVP
committed
C++: Accept test changes.
1 parent 0839c1a commit 79fb6a6

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

‎cpp/ql/test/library-tests/dataflow/dataflow-tests/self_parameter_flow.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ void callincr(unsigned char *s) // $ ast-def=s
1010

1111
void test(unsigned char *s) // $ ast-def=s
1212
{
13-
callincr(s); // $ MISSING: flow
13+
callincr(s); // $ flow
1414
}

‎cpp/ql/test/query-tests/Security/CWE/CWE-119/semmle/tests/OverflowDestination.expected

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,19 @@ edges
88
| overflowdestination.cpp:23:45:23:48 | argv indirection | overflowdestination.cpp:30:17:30:20 | arg1 indirection |
99
| overflowdestination.cpp:23:45:23:48 | argv indirection | overflowdestination.cpp:30:17:30:20 | arg1 indirection |
1010
| overflowdestination.cpp:43:8:43:10 | fgets output argument | overflowdestination.cpp:46:15:46:17 | src indirection |
11+
| overflowdestination.cpp:50:52:50:54 | src indirection | overflowdestination.cpp:53:9:53:12 | memcpy output argument |
1112
| overflowdestination.cpp:50:52:50:54 | src indirection | overflowdestination.cpp:53:15:53:17 | src indirection |
1213
| overflowdestination.cpp:50:52:50:54 | src indirection | overflowdestination.cpp:53:15:53:17 | src indirection |
14+
| overflowdestination.cpp:50:52:50:54 | src indirection | overflowdestination.cpp:54:9:54:12 | memcpy output argument |
15+
| overflowdestination.cpp:53:9:53:12 | memcpy output argument | overflowdestination.cpp:54:9:54:12 | memcpy output argument |
16+
| overflowdestination.cpp:54:9:54:12 | memcpy output argument | overflowdestination.cpp:54:9:54:12 | memcpy output argument |
1317
| overflowdestination.cpp:57:52:57:54 | src indirection | overflowdestination.cpp:64:16:64:19 | src2 indirection |
1418
| overflowdestination.cpp:57:52:57:54 | src indirection | overflowdestination.cpp:64:16:64:19 | src2 indirection |
1519
| overflowdestination.cpp:73:8:73:10 | fgets output argument | overflowdestination.cpp:75:30:75:32 | src indirection |
1620
| overflowdestination.cpp:73:8:73:10 | fgets output argument | overflowdestination.cpp:76:30:76:32 | src indirection |
21+
| overflowdestination.cpp:75:30:75:32 | overflowdest_test2 output argument | overflowdestination.cpp:76:30:76:32 | src indirection |
1722
| overflowdestination.cpp:75:30:75:32 | src indirection | overflowdestination.cpp:50:52:50:54 | src indirection |
23+
| overflowdestination.cpp:75:30:75:32 | src indirection | overflowdestination.cpp:75:30:75:32 | overflowdest_test2 output argument |
1824
| overflowdestination.cpp:76:30:76:32 | src indirection | overflowdestination.cpp:57:52:57:54 | src indirection |
1925
nodes
2026
| main.cpp:6:27:6:30 | argv indirection | semmle.label | argv indirection |
@@ -28,15 +34,20 @@ nodes
2834
| overflowdestination.cpp:43:8:43:10 | fgets output argument | semmle.label | fgets output argument |
2935
| overflowdestination.cpp:46:15:46:17 | src indirection | semmle.label | src indirection |
3036
| overflowdestination.cpp:50:52:50:54 | src indirection | semmle.label | src indirection |
37+
| overflowdestination.cpp:53:9:53:12 | memcpy output argument | semmle.label | memcpy output argument |
3138
| overflowdestination.cpp:53:15:53:17 | src indirection | semmle.label | src indirection |
3239
| overflowdestination.cpp:53:15:53:17 | src indirection | semmle.label | src indirection |
40+
| overflowdestination.cpp:54:9:54:12 | memcpy output argument | semmle.label | memcpy output argument |
3341
| overflowdestination.cpp:57:52:57:54 | src indirection | semmle.label | src indirection |
3442
| overflowdestination.cpp:64:16:64:19 | src2 indirection | semmle.label | src2 indirection |
3543
| overflowdestination.cpp:64:16:64:19 | src2 indirection | semmle.label | src2 indirection |
3644
| overflowdestination.cpp:73:8:73:10 | fgets output argument | semmle.label | fgets output argument |
45+
| overflowdestination.cpp:75:30:75:32 | overflowdest_test2 output argument | semmle.label | overflowdest_test2 output argument |
3746
| overflowdestination.cpp:75:30:75:32 | src indirection | semmle.label | src indirection |
3847
| overflowdestination.cpp:76:30:76:32 | src indirection | semmle.label | src indirection |
3948
subpaths
49+
| overflowdestination.cpp:75:30:75:32 | src indirection | overflowdestination.cpp:50:52:50:54 | src indirection | overflowdestination.cpp:53:9:53:12 | memcpy output argument | overflowdestination.cpp:75:30:75:32 | overflowdest_test2 output argument |
50+
| overflowdestination.cpp:75:30:75:32 | src indirection | overflowdestination.cpp:50:52:50:54 | src indirection | overflowdestination.cpp:54:9:54:12 | memcpy output argument | overflowdestination.cpp:75:30:75:32 | overflowdest_test2 output argument |
4051
#select
4152
| overflowdestination.cpp:30:2:30:8 | call to strncpy | main.cpp:6:27:6:30 | argv indirection | overflowdestination.cpp:30:17:30:20 | arg1 indirection | To avoid overflow, this operation should be bounded by destination-buffer size, not source-buffer size. |
4253
| overflowdestination.cpp:30:2:30:8 | call to strncpy | main.cpp:6:27:6:30 | argv indirection | overflowdestination.cpp:30:17:30:20 | arg1 indirection | To avoid overflow, this operation should be bounded by destination-buffer size, not source-buffer size. |

0 commit comments

Comments
 (0)