Skip to content

Commit 7a4b74d

Browse files
Jami CogswellJami Cogswell
authored andcommitted
C#: fix typo with outdated sink msg location
1 parent 6c46cd9 commit 7a4b74d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -212,20 +212,20 @@ module ModelValidation {
212212
result = "Invalid kind \"" + kind + "\" in summary model."
213213
)
214214
or
215-
exists(string kind | sinkModel(_, _, _, _, _, _, _, kind, _) |
215+
exists(string kind, string msg | sinkModel(_, _, _, _, _, _, _, kind, _) |
216216
not kind instanceof ValidSinkKind and
217-
result = "Invalid kind \"" + kind + "\" in sink model."
218-
)
219-
or
220-
exists(string kind, string msg | sourceModel(_, _, _, _, _, _, _, kind, _) |
221-
not kind instanceof ValidSourceKind and
222217
msg = "Invalid kind \"" + kind + "\" in sink model." and
223218
// The part of this message that refers to outdated sink kinds can be deleted after June 1st, 2024.
224219
if kind instanceof OutdatedSinkKind
225220
then result = msg + " " + kind.(OutdatedSinkKind).outdatedMessage()
226221
else result = msg
227222
)
228223
or
224+
exists(string kind | sourceModel(_, _, _, _, _, _, _, kind, _) |
225+
not kind instanceof ValidSourceKind and
226+
result = "Invalid kind \"" + kind + "\" in source model."
227+
)
228+
or
229229
exists(string kind | neutralModel(_, _, _, _, kind, _) |
230230
not kind instanceof ValidNeutralKind and
231231
result = "Invalid kind \"" + kind + "\" in neutral model."

0 commit comments

Comments
 (0)