Add dashes to SHA algorithm names in Encryption.qll

egregius313 · egregius313 · commit 7cfe78a52d45 · 2023-08-15T23:42:17.000-04:00
diff --git a/java/ql/lib/semmle/code/java/security/Encryption.qll b/java/ql/lib/semmle/code/java/security/Encryption.qll
@@ -270,7 +270,7 @@ string getInsecureAlgorithmRegex() {
 string getASecureAlgorithmName() {
   result =
     [
-      "RSA", "SHA256", "SHA512", "CCM", "GCM", "AES(?![^a-zA-Z](ECB|CBC/PKCS[57]Padding))",
+      "RSA", "SHA-?256", "SHA-?512", "CCM", "GCM", "AES(?![^a-zA-Z](ECB|CBC/PKCS[57]Padding))",
       "Blowfish", "ECIES"
     ]
 }

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ string getInsecureAlgorithmRegex() {`
`270`	`270`	`string getASecureAlgorithmName() {`
`271`	`271`	`result =`
`272`	`272`	`[`
`273`		`- "RSA", "SHA256", "SHA512", "CCM", "GCM", "AES(?![^a-zA-Z](ECB\|CBC/PKCS[57]Padding))",`
	`273`	`+ "RSA", "SHA-?256", "SHA-?512", "CCM", "GCM", "AES(?![^a-zA-Z](ECB\|CBC/PKCS[57]Padding))",`
`274`	`274`	`"Blowfish", "ECIES"`
`275`	`275`	`]`
`276`	`276`	`}`