put each new sink in its own framework

Author: am0o0

go/ql/lib/go.qll

@@ -64,3 +64,6 @@ import semmle.go.frameworks.XPath
 import semmle.go.frameworks.Yaml
 import semmle.go.frameworks.Zap
 import semmle.go.security.FlowSources
+import semmle.go.frameworks.Afero
+import semmle.go.frameworks.Iris
+import semmle.go.frameworks.Fiber

go/ql/test/library-tests/semmle/go/security/FileSystemAccess/Query.expected renamed to go/ql/test/library-tests/semmle/go/frameworks/Afero/Query.expected

@@ -1,21 +1,9 @@
 package main
 
-//go:generate depstubber -vendor  github.com/beego/beego/v2/server/web Controller Run,Router
-//go:generate depstubber -vendor  github.com/beego/beego/v2/server/web/context BeegoOutput,Context
-//go:generate depstubber -vendor  github.com/gin-gonic/gin Context Default
-//go:generate depstubber -vendor  github.com/gofiber/fiber/v2 Ctx New
-//go:generate depstubber -vendor  github.com/kataras/iris/v12/context Context
-//go:generate depstubber -vendor  github.com/labstack/echo/v4 Context New
 //go:generate depstubber -vendor  github.com/spf13/afero Afero,RegexpFs,HttpFs,ReadOnlyFs,MemMapFs,OsFs,BasePathFs WriteReader,SafeWriteReader,WriteFile,ReadFile,ReadDir,NewOsFs,NewRegexpFs,NewReadOnlyFs,NewCacheOnReadFs,,NewHttpFs,NewBasePathFs,NewIOFS
 
 import (
 	"fmt"
-	beego "github.com/beego/beego/v2/server/web"
-	BeegoContext "github.com/beego/beego/v2/server/web/context"
-	"github.com/gin-gonic/gin"
-	"github.com/gofiber/fiber/v2"
-	"github.com/kataras/iris/v12/context"
-	"github.com/labstack/echo/v4"
 	"github.com/spf13/afero"
 	"net/http"
 	"os"
@@ -26,13 +14,6 @@ func main() {
 	return
 }
 
-func BeegoController(beegoController beego.Controller) {
-	beegoOutput := BeegoContext.BeegoOutput{}
-	beegoOutput.Download("filepath", "license.txt") // $ FileSystemAccess="filepath"
-	buffer := make([]byte, 10)
-	_ = beegoController.SaveToFileWithBuffer("filenameExistsInForm", "filepath", buffer) // $ FileSystemAccess="filepath"
-}
-
 func Afero(writer http.ResponseWriter, request *http.Request) {
 	filepath := request.URL.Query()["filepath"][0]
 	//osFS := afero.NewMemMapFs()
@@ -97,52 +78,3 @@ func Afero(writer http.ResponseWriter, request *http.Request) {
 	fmt.Println(afero.ReadFile(basePathFs, filepath))
 	afero.ReadFile(basePathFs, filepath)
 }
-
-func Echo() {
-	e := echo.New()
-	e.GET("/", func(c echo.Context) error {
-		filepath := c.QueryParam("filePath")
-		return c.File(filepath) // $ FileSystemAccess=filepath
-	})
-
-	e.GET("/attachment", func(c echo.Context) error {
-		filepath := c.QueryParam("filePath")
-		return c.Attachment(filepath, "file name in response") // $ FileSystemAccess=filepath
-	})
-	_ = e.Start(":1323")
-}
-
-func Fiber() {
-	app := fiber.New()
-	app.Get("/b", func(c *fiber.Ctx) error {
-		filepath := c.Params("filepath")
-		header, _ := c.FormFile("f")
-		_ = c.SaveFile(header, filepath) // $ FileSystemAccess=filepath
-		return c.SendFile(filepath)      // $ FileSystemAccess=filepath
-	})
-	_ = app.Listen(":3000")
-}
-
-func IrisTest(ctx context.Context) {
-	filepath := ctx.URLParam("filepath")
-	_ = ctx.SendFile(filepath, "file")               // $ FileSystemAccess=filepath
-	_ = ctx.SendFileWithRate(filepath, "file", 0, 0) // $ FileSystemAccess=filepath
-	_ = ctx.ServeFile(filepath)                      // $ FileSystemAccess=filepath
-	_ = ctx.ServeFileWithRate(filepath, 0, 0)        // $ FileSystemAccess=filepath
-	_, _, _ = ctx.UploadFormFiles(filepath, nil)     // $ FileSystemAccess=filepath
-	_, fileHeader, _ := ctx.FormFile("file")
-	_, _ = ctx.SaveFormFile(fileHeader, filepath) // $ FileSystemAccess=filepath
-
-}
-func Gin() {
-	router := gin.Default()
-	router.POST("/FormUploads", func(c *gin.Context) {
-		filepath := c.Query("filepath")
-		c.File(filepath)                                    // $ FileSystemAccess=filepath
-		http.ServeFile(c.Writer, c.Request, filepath)       // $ FileSystemAccess=filepath
-		c.FileAttachment(filepath, "file name in response") // $ FileSystemAccess=filepath
-		file, _ := c.FormFile("afile")
-		_ = c.SaveUploadedFile(file, filepath) // $ FileSystemAccess=filepath
-	})
-	_ = router.Run()
-}