Skip to content

Commit 7d6abb4

Browse files
committed
JS: Disable diff-informedness for full SSRF
Partial SSRF uses its result in a way that prevents diff-informedness
1 parent d3ee658 commit 7d6abb4

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

python/ql/lib/semmle/python/security/dataflow/ServerSideRequestForgeryQuery.qll

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,10 @@ private module FullServerSideRequestForgeryConfig implements DataFlow::ConfigSig
3030
node instanceof FullUrlControlSanitizer
3131
}
3232

33-
predicate observeDiffInformedIncrementalMode() { any() }
34-
35-
Location getASelectedSinkLocation(DataFlow::Node sink) {
36-
result = sink.(Sink).getLocation()
37-
or
38-
result = sink.(Sink).getRequest().getLocation()
33+
predicate observeDiffInformedIncrementalMode() {
34+
// The partial request forgery query depends on `fullyControlledRequest` to reject alerts about
35+
// such full-controlled requests, regardless of the associated source.
36+
none()
3937
}
4038
}
4139

0 commit comments

Comments
 (0)