Skip to content

Commit 7e87a7c

Browse files
committed
python: rewrite argumentPositionMatch
to not use the call graph.
1 parent b294f48 commit 7e87a7c

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/TypeTrackerSpecific.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,13 +170,12 @@ private import semmle.python.dataflow.new.internal.DataFlowDispatch as DataFlowD
170170

171171
pragma[noinline]
172172
private predicate argumentPositionMatch(
173-
DataFlowPublic::CallCfgNode call, DataFlowPublic::ArgumentNode arg,
173+
DataFlowPublic::CallCfgNode call, DataFlowPublic::Node arg,
174174
DataFlowDispatch::ParameterPosition ppos
175175
) {
176-
exists(DataFlowDispatch::ArgumentPosition apos, DataFlowPrivate::DataFlowCall c |
177-
c.getNode() = call.asCfgNode() and
178-
arg.argumentOf(c, apos) and
179-
DataFlowDispatch::parameterMatch(ppos, apos)
176+
exists(DataFlowDispatch::ArgumentPosition apos |
177+
DataFlowDispatch::parameterMatch(ppos, apos) and
178+
DataFlowDispatch::normalCallArg(call.getNode(), arg, apos)
180179
)
181180
}
182181

0 commit comments

Comments
 (0)