Skip to content

Commit 83cef78

Browse files
authored
Merge pull request github#15783 from github/smowton/fix/extractor-information-fractional-percentage
Java: extractor information: tolerate fractional percentages
2 parents 0c93641 + 0403954 commit 83cef78

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

java/ql/integration-tests/all-platforms/java/buildless-erroneous/ExtractorInformation.expected

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
| Number of lines of code | 7 |
1313
| Number of lines of code with extension java | 7 |
1414
| Percentage of calls with call target | 20 |
15+
| Percentage of expressions with known type | 14 |
1516
| Total number of diagnostics from CodeQL Java extractor | 12 |
1617
| Total number of lines | 13 |
1718
| Total number of lines with extension java | 13 |

java/ql/src/Telemetry/ExtractorInformation.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ where
159159
extractorTotalDiagnostics(key, value) or
160160
CallTargetStatsReport::numberOfOk(key, value) or
161161
CallTargetStatsReport::numberOfNotOk(key, value) or
162-
CallTargetStatsReport::percentageOfOk(key, value) or
162+
CallTargetStatsReport::percentageOfOk(key, any(float x | value = x.floor())) or
163163
ExprTypeStatsReport::numberOfOk(key, value) or
164164
ExprTypeStatsReport::numberOfNotOk(key, value) or
165-
ExprTypeStatsReport::percentageOfOk(key, value)
165+
ExprTypeStatsReport::percentageOfOk(key, any(float x | value = x.floor()))
166166
)
167167
select key, value

0 commit comments

Comments
 (0)