Skip to content

Commit 882a985

Browse files
committed
Dataflow: Remove useless join.
1 parent 262f64f commit 882a985

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2166,13 +2166,12 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
21662166
private predicate flowThroughIntoCall(
21672167
DataFlowCall call, ArgNodeEx arg, ParamNodeEx p, Ap argAp, Ap ap
21682168
) {
2169-
exists(ApApprox argApa, Typ argT, TypOption argStored, boolean emptyArgAp |
2169+
exists(Typ argT, TypOption argStored, boolean emptyArgAp |
21702170
returnFlowsThrough(_, _, _, _, pragma[only_bind_into](p), pragma[only_bind_into](argT),
2171-
pragma[only_bind_into](argAp), pragma[only_bind_into](argApa),
2172-
pragma[only_bind_into](argStored), ap) and
2171+
pragma[only_bind_into](argAp), _, pragma[only_bind_into](argStored), ap) and
21732172
flowIntoCallApaTaken(call, _, pragma[only_bind_into](arg), p, emptyArgAp) and
2174-
fwdFlow(arg, _, _, _, pragma[only_bind_into](argT), pragma[only_bind_into](argAp),
2175-
pragma[only_bind_into](argApa), pragma[only_bind_into](argStored)) and
2173+
fwdFlow(arg, _, _, _, pragma[only_bind_into](argT), pragma[only_bind_into](argAp), _,
2174+
pragma[only_bind_into](argStored)) and
21762175
if argAp instanceof ApNil then emptyArgAp = true else emptyArgAp = false
21772176
)
21782177
}

0 commit comments

Comments
 (0)